Implement Topdown metric support #318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for the topdown metrics (fe-bound, be-bound etc.) as seen in perf
bmario
requested changes
Feb 14, 2024
Comment on lines
+99
to
+100
| //topdown | ||
| bool topdown; |
There was a problem hiding this comment.
Suggested change
| //topdown | |
| bool topdown; | |
| bool topdown; |
| @@ -74,6 +75,8 @@ class ScopeMonitor : public PollMonitor | |||
| std::unique_ptr<perf::sample::Writer> sample_writer_; | |||
| std::unique_ptr<perf::counter::group::Writer> group_counter_writer_; | |||
| std::unique_ptr<perf::counter::userspace::Writer> userspace_counter_writer_; | |||
|
|
|||
| * This file is part of the lo2s software. | ||
| * Linux OTF2 sampling | ||
| * | ||
| * Copyright (c) 2021, |
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2021, | |
| * Copyright (c) 2024, |
| * This file is part of the lo2s software. | ||
| * Linux OTF2 sampling | ||
| * | ||
| * Copyright (c) 2018, |
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2018, | |
| * Copyright (c) 2024, |
| uint64_t slots; | ||
| uint64_t retiring; | ||
| uint64_t bad_spec; | ||
| uint64_t fe_bound; |
Comment on lines
+77
to
+78
| topdown_writer_ = std::make_unique<perf::counter::topdown::Writer>(scope, parent.trace()); | ||
| add_fd(topdown_writer_->fd()); |
| @@ -344,6 +345,8 @@ void parse_program_options(int argc, const char** argv) | |||
| .metavar("MSEC") | |||
| .default_value("100"); | |||
|
|
|||
| topdown_options.toggle("topdown", "Enable recording of topdown metrics"); | |||
There was a problem hiding this comment.
It's a special perf metric. No need for groups of one.
| ByExecutionScope(groups_.get_parent(writer_scope))), | ||
| otf2::definition::location::location_type::cpu_thread); | ||
|
|
||
| comm_locations_group_.add_member(intern_location); |
There was a problem hiding this comment.
Why adding the location to comm_locations_group_? Without that this function is identical to
metric_writer(MeasurementScope::topdown(scope)).
| @@ -170,6 +170,9 @@ set(SOURCE_FILES | |||
| src/perf/counter/userspace/reader.cpp | |||
|
|
|||
| src/perf/counter/userspace/writer.cpp | |||
| src/perf/counter/topdown/reader.cpp | |||
|
|
|||
| otf2::common::metric_occurence::async, otf2::common::recorder_kind::abstract); | ||
| topdown_metric_class_->add_member(metric_member( | ||
| "slots", "Number of UOPS slots", otf2::common::metric_mode::absolute_point, | ||
| otf2::common::type::int64, "slots")); |
There was a problem hiding this comment.
the second "slots" is the unit of the metric. uops seems to be the obvious choice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for the topdown metrics (fe-bound, be-bound etc.) as seen in perf