fix(radare): Fix Radare Support #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmario
requested changes
Sep 26, 2023
cvonelm
force-pushed
the
issue-286-libradare-fix
branch
from
71f6a07
to
bf08186
Compare
bmario
reviewed
Sep 26, 2023
CMakeLists.txt
Outdated
Comment on lines
273
to
274
| target_include_directories(lo2s PRIVATE ${Radare_INCLUDE_DIRS}) | ||
| #set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${Radare_CFLAGS}") |
There was a problem hiding this comment.
Suggested change
| target_include_directories(lo2s PRIVATE ${Radare_INCLUDE_DIRS}) | |
| #set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${Radare_CFLAGS}") |
That's not required when you use CMake targets.
bmario
approved these changes
Sep 26, 2023
Version 5.8.0 of Radare2 introduced breaking API changes. This commit fixes them and bumps the minimum Radare2 version requirement. Furthermore our homegrown Radare CMake Script did not work with newer Radare versions, so use pkg-config instead.
cvonelm
force-pushed
the
issue-286-libradare-fix
branch
from
0bda084
to
fcb2f96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were breaking API changes in Radare.
Furthermore our homegrown Radare CMake Script did not work with newer Radare versions, so use pkg-config instead
This fixes #286