Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing creates (visual) duplicates #25

Closed
linwiz opened this issue Feb 26, 2016 · 2 comments
Closed

Importing creates (visual) duplicates #25

linwiz opened this issue Feb 26, 2016 · 2 comments
Labels

Comments

@linwiz
Copy link

linwiz commented Feb 26, 2016

If you import a mpsites file while entries already exist then duplicate entries are created. Maybe the user should be prompted which entry to keep for each site and then discard the other one.

@ttyridal ttyridal added the bug label Feb 28, 2016
@ttyridal ttyridal changed the title Importing creates duplicates Importing creates (visual) duplicates Aug 4, 2016
@ttyridal
Copy link
Owner

ttyridal commented Aug 4, 2016

As long as the match string is not modified on existing entry (ie matches sitename) it will actually not create a duplicate. It will look that way, since it's appended in the gui, but on storage the existing entry is overwritten (without any warnings)

So if you close and re-open the config window you'll not have duplicates.

Now, silent overwrite is probably not a desired behaviour...

ttyridal added a commit that referenced this issue Aug 8, 2016
@ttyridal
Copy link
Owner

ttyridal commented Aug 8, 2016

fix committed and beta software released

@ttyridal ttyridal closed this as completed Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants