This repository has been archived by the owner on Dec 19, 2021. It is now read-only.
Fix bug that break remote ip sometime. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup connection object when release request.
joeyhub
added a commit
to joeyhub/mod_remoteip-httpd22
that referenced
this pull request
Jul 21, 2015
|
I can confirm this bug exists and it still appears to be in trunk. I receive empty ips for subsequent requests from keepalive connections that are proxied. This can also be fixed with various proxy configurations. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
同じクライアントからリクエストを何度か連続して送るとremote_ipが壊れる問題を直してみました。
こんなことが起きていたみたいです。
c->remote_ipにr->hookから確保した文字列を設定rが破棄されるcはまだ破棄されないcが使いまわされるc->remote_ipは開放済みの場所を指しているc->remote_ipが指している場所に全然関係ないものが入ってしまう