This repository has been archived by the owner on Jun 28, 2024. It is now read-only.
Test_parse_rgb_number #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tthijm
reviewed
Jun 12, 2024
README.md
Outdated
| @@ -81,6 +89,18 @@ test\_\_human_join | |||
| The coverage improvement is +100%. | |||
| The coverage has been improved, because `_human_join` used to not be tested, while the new `test__human_join` considers every branch to be taken. | |||
|
|
|||
| #### Frank | |||
|
|
|||
| tests\test_colour.py | |||
There was a problem hiding this comment.
Maybe change this to test_from_str_failures for consistency?
README.md
Outdated
|
|
||
| \_human_join | ||
|
|
||
| [commit](https://github.com/tthijm/sep/commit/88c98ebc05c4d67bcdce7d3046ffa786f79b9284) | ||
|
|
||
|  | ||
|
|
||
| #### Frank | ||
|
|
||
| \parse_rgb_number |
tthijm
approved these changes
Jun 13, 2024
tthijm
suggested changes
Jun 13, 2024
README.md
Outdated
|
|
||
|  | ||
|
|
||
| The coverage of the function has improved from the originaly 60% to 100%, since the other two branches (1 and 3) were also covered. |
There was a problem hiding this comment.
The original coverage should be taken from coverage which was 78%.
tthijm
approved these changes
Jun 14, 2024
tthijm
suggested changes
Jun 14, 2024
Co-authored-by: tthijm <[email protected]>
tthijm
previously approved these changes
Jun 15, 2024
tthijm
approved these changes
Jun 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added coverage for parse_rgb_number()