fail with error if no processes are parsed from Procfile

tsuru · Feb 6, 2017 · a71ef6e · a71ef6e
1 parent 09ccd78
commit a71ef6e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/tasks.go b/tasks.go
@@ -147,6 +147,9 @@ func loadProcesses(t *TsuruYaml) error {
 			processes[p[1]] = strings.Trim(p[2], " ")
 		}
 	}
+	if len(processes) == 0 {
+		return fmt.Errorf("invalid Procfile, no processes found in %q", procfile)
+	}
 	t.Processes = processes
 	return nil
 }

diff --git a/tasks_test.go b/tasks_test.go
@@ -187,8 +187,8 @@ func (s *S) TestDontLoadWrongProcfile(c *check.C) {
 	c.Assert(s.fs.HasAction(fmt.Sprintf("create %s", procfilePath)), check.Equals, true)
 	t := TsuruYaml{}
 	err = loadProcesses(&t)
-	c.Assert(err, check.IsNil)
-	c.Assert(t.Processes, check.DeepEquals, map[string]string{})
+	c.Assert(err, check.NotNil)
+	c.Assert(err.Error(), check.Equals, `invalid Procfile, no processes found in "web:\n\t@python test.py"`)
 }
 
 func (s *S) TestSaveAppEnvsFile(c *check.C) {