[Spaces Management] Ensure current badge can only appear for single e…

…ntry (elastic#193195) ## Summary Closes elastic#192811 ### Checklist Delete any items that are not applicable to this PR. - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or (cherry picked from commit 5bf4501)
tsullivan · Sep 18, 2024 · 99152fe · 99152fe
1 parent 3a62655
commit 99152fe
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 15 deletions.
diff --git a/x-pack/plugins/spaces/public/management/spaces_grid/spaces_grid_page.test.tsx b/x-pack/plugins/spaces/public/management/spaces_grid/spaces_grid_page.test.tsx
@@ -19,7 +19,6 @@ import { mountWithIntl, shallowWithIntl } from '@kbn/test-jest-helpers';
 
 import { SpacesGridPage } from './spaces_grid_page';
 import { SpaceAvatarInternal } from '../../space_avatar/space_avatar_internal';
-import type { SpacesManager } from '../../spaces_manager';
 import { spacesManagerMock } from '../../spaces_manager/mocks';
 
 const spaces = [
@@ -73,7 +72,7 @@ describe('SpacesGridPage', () => {
 
     const wrapper = shallowWithIntl(
       <SpacesGridPage
-        spacesManager={spacesManager as unknown as SpacesManager}
+        spacesManager={spacesManager}
         getFeatures={featuresStart.getFeatures}
         notifications={notificationServiceMock.createStartContract()}
         getUrlForApp={getUrlForApp}
@@ -133,7 +132,7 @@ describe('SpacesGridPage', () => {
 
     const wrapper = shallowWithIntl(
       <SpacesGridPage
-        spacesManager={spacesManager as unknown as SpacesManager}
+        spacesManager={spacesManager}
         getFeatures={featuresStart.getFeatures}
         notifications={notificationServiceMock.createStartContract()}
         getUrlForApp={getUrlForApp}
@@ -163,13 +162,21 @@ describe('SpacesGridPage', () => {
   });
 
   it('renders a "current" badge for the current space', async () => {
-    spacesManager.getActiveSpace.mockResolvedValue(spaces[2]);
-    const current = await spacesManager.getActiveSpace();
-    expect(current.id).toBe('custom-2');
+    const spacesWithCurrent = [
+      { id: 'default', name: 'Default', disabledFeatures: [], _reserved: true },
+      { id: 'test-1', name: 'Test', disabledFeatures: [] },
+      { id: 'test-2', name: 'Test', disabledFeatures: [] },
+    ];
+    const spacesManagerWithCurrent = spacesManagerMock.create();
+    spacesManagerWithCurrent.getSpaces = jest.fn().mockResolvedValue(spacesWithCurrent);
+    spacesManagerWithCurrent.getActiveSpace.mockResolvedValue(spacesWithCurrent[2]);
+
+    const current = await spacesManagerWithCurrent.getActiveSpace();
+    expect(current.id).toBe('test-2');
 
     const wrapper = mountWithIntl(
       <SpacesGridPage
-        spacesManager={spacesManager as unknown as SpacesManager}
+        spacesManager={spacesManagerWithCurrent}
         getFeatures={featuresStart.getFeatures}
         notifications={notificationServiceMock.createStartContract()}
         getUrlForApp={getUrlForApp}
@@ -189,10 +196,20 @@ describe('SpacesGridPage', () => {
     await act(async () => {});
     wrapper.update();
 
-    const activeRow = wrapper.find('[data-test-subj="spacesListTableRow-custom-2"]');
+    const activeRow = wrapper.find('[data-test-subj="spacesListTableRow-test-2"]');
     const nameCell = activeRow.find('[data-test-subj="spacesListTableRowNameCell"]');
     const activeBadge = nameCell.find('EuiBadge');
     expect(activeBadge.text()).toBe('current');
+
+    // ensure that current badge appears only once
+    const currentBadges = wrapper.findWhere((node) => {
+      return (
+        node.type() === 'span' &&
+        node.prop('data-test-subj') &&
+        node.prop('data-test-subj').includes('spacesListCurrentBadge')
+      );
+    });
+    expect(currentBadges.length).toBe(1);
   });
 
   it('renders a non-clickable "switch" action for the current space', async () => {
@@ -202,7 +219,7 @@ describe('SpacesGridPage', () => {
 
     const wrapper = mountWithIntl(
       <SpacesGridPage
-        spacesManager={spacesManager as unknown as SpacesManager}
+        spacesManager={spacesManager}
         getFeatures={featuresStart.getFeatures}
         notifications={notificationServiceMock.createStartContract()}
         getUrlForApp={getUrlForApp}
@@ -234,7 +251,7 @@ describe('SpacesGridPage', () => {
 
     const wrapper = mountWithIntl(
       <SpacesGridPage
-        spacesManager={spacesManager as unknown as SpacesManager}
+        spacesManager={spacesManager}
         getFeatures={featuresStart.getFeatures}
         notifications={notificationServiceMock.createStartContract()}
         getUrlForApp={getUrlForApp}
@@ -265,7 +282,7 @@ describe('SpacesGridPage', () => {
 
     const wrapper = mountWithIntl(
       <SpacesGridPage
-        spacesManager={spacesManager as unknown as SpacesManager}
+        spacesManager={spacesManager}
         getFeatures={featuresStart.getFeatures}
         notifications={notificationServiceMock.createStartContract()}
         getUrlForApp={getUrlForApp}
@@ -295,7 +312,7 @@ describe('SpacesGridPage', () => {
 
     const wrapper = mountWithIntl(
       <SpacesGridPage
-        spacesManager={spacesManager as unknown as SpacesManager}
+        spacesManager={spacesManager}
         getFeatures={featuresStart.getFeatures}
         notifications={notificationServiceMock.createStartContract()}
         getUrlForApp={getUrlForApp}
@@ -331,7 +348,7 @@ describe('SpacesGridPage', () => {
 
     const wrapper = shallowWithIntl(
       <SpacesGridPage
-        spacesManager={spacesManager as unknown as SpacesManager}
+        spacesManager={spacesManager}
         getFeatures={featuresStart.getFeatures}
         notifications={notifications}
         getUrlForApp={getUrlForApp}
@@ -367,7 +384,7 @@ describe('SpacesGridPage', () => {
 
     const wrapper = shallowWithIntl(
       <SpacesGridPage
-        spacesManager={spacesManager as unknown as SpacesManager}
+        spacesManager={spacesManager}
         getFeatures={() => Promise.reject(error)}
         notifications={notifications}
         getUrlForApp={getUrlForApp}

diff --git a/x-pack/plugins/spaces/public/management/spaces_grid/spaces_grid_page.tsx b/x-pack/plugins/spaces/public/management/spaces_grid/spaces_grid_page.tsx
@@ -284,7 +284,7 @@ export class SpacesGridPage extends Component<Props, State> {
                 {value}
               </EuiLink>
             </EuiFlexItem>
-            {this.state.activeSpace?.name === rowRecord.name && (
+            {this.state.activeSpace?.id === rowRecord.id && (
               <EuiFlexItem grow={false}>
                 <EuiBadge color="primary" data-test-subj={`spacesListCurrentBadge-${rowRecord.id}`}>
                   {i18n.translate('xpack.spaces.management.spacesGridPage.currentSpaceMarkerText', {