Use npm instead of yarn to build Theia

Fixes eclipse-theia#13948 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <[email protected]>
tsmaeder · Dec 17, 2024 · a1af570 · a1af570
1 parent 4e3b183
commit a1af570
Show file tree

Hide file tree

Showing 69 changed files with 31,247 additions and 14,381 deletions.
diff --git a/.editorconfig b/.editorconfig
@@ -1,7 +1,6 @@
 root = true
 
 [*]
-insert_final_newline = true
 end_of_line = lf
 indent_style = space
 

diff --git a/.eslintrc.js b/.eslintrc.js
diff --git a/.gitattributes b/.gitattributes
@@ -0,0 +1 @@
+dev-packages/*/bin/*.js text eol=lf
diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml
@@ -34,16 +34,16 @@ jobs:
       - name: Install and Build
         shell: bash
         run: |
-          yarn global add node-gyp
-          yarn --skip-integrity-check --network-timeout 100000
+          npm install -g node-gyp
+          npm ci
           ./scripts/check_git_status.sh
         env:
           NODE_OPTIONS: --max_old_space_size=4096
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # https://github.com/microsoft/vscode-ripgrep/issues/9
 
       - name: Lint
         run: |
-          yarn lint
+          npm run lint
 
   build:
     name: Build and Test (${{ matrix.os }}, node-${{ matrix.node }})
@@ -72,44 +72,38 @@ jobs:
         with:
           python-version: '3.11'
 
-      - name: Install
+      - name: Build
         shell: bash
         run: |
-          yarn global add node-gyp
-          yarn --skip-integrity-check --network-timeout 100000
+          npm install -g node-gyp
+          npm ci
+          npm run build
+          git status
           ./scripts/check_git_status.sh
         env:
           NODE_OPTIONS: --max_old_space_size=4096
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # https://github.com/microsoft/vscode-ripgrep/issues/9
 
+
       - name: Download Plugins
         if: runner.os == 'Linux'
         shell: bash
         run: |
-          yarn -s download:plugins --rate-limit 3
-
-      - name: Build
-        shell: bash
-        run: |
-          yarn build:examples
-          ./scripts/check_git_status.sh
-        env:
-          NODE_OPTIONS: --max_old_space_size=4096
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # https://github.com/microsoft/vscode-ripgrep/issues/9
-
+          npm run download:plugins -- --rate-limit 3
+          
       - name: Test (headless)
         if: matrix.tests != 'skip'
         shell: bash
         run: |
-          yarn browser rebuild
-          yarn test:theia
+          npm run rebuild:browser
+          npm run test:theia
 
       - name: Test (browser)
         if: matrix.tests != 'skip' && runner.os == 'Linux'
         run: |
-          xvfb-run -a yarn browser test
+          xvfb-run -a npm run test:browser
 
       - name: Test (electron)
         if: matrix.tests != 'skip' && runner.os == 'Linux'
         run: |
-          xvfb-run -a yarn electron test
+          xvfb-run -a npm run test:electron
diff --git a/.github/workflows/license-check.yml b/.github/workflows/license-check.yml
@@ -48,4 +48,4 @@ jobs:
         if: matrix.tests != 'skip'
         shell: bash
         run: |
-          yarn license:check
+          npm run license:check
diff --git a/.github/workflows/native-dependencies.yml b/.github/workflows/native-dependencies.yml
@@ -27,21 +27,21 @@ jobs:
       - name: Install and Build
         shell: bash
         run: |
-          yarn --skip-integrity-check --network-timeout 100000
+          npm ci
         env:
           NODE_OPTIONS: --max_old_space_size=4096
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # https://github.com/microsoft/vscode-ripgrep/issues/9
 
       - name: Build Browser App
         shell: bash
         run: |
-          yarn browser build
+          npm run build:browser
         env:
           NODE_OPTIONS: --max_old_space_size=4096
 
       - name: Zip Native Dependencies
         shell: bash
-        run: yarn zip:native:dependencies
+        run: npm run zip:native:dependencies
 
       - name: Upload Artifacts
         uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3 

diff --git a/.github/workflows/performance-tests.yml b/.github/workflows/performance-tests.yml
@@ -28,20 +28,20 @@ jobs:
       - name: Build
         shell: bash
         run: |
-          yarn global add node-gyp
-          yarn --skip-integrity-check --network-timeout 100000 --ignore-engines
-          yarn build:examples
+          npm install -g  node-gyp
+          npm ci
+          npm run build
         env:
           NODE_OPTIONS: --max_old_space_size=4096
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # https://github.com/microsoft/vscode-ripgrep/issues/9
 
       - name: Performance (browser)
         shell: bash
-        run: yarn performance:startup:browser
+        run: npm run performance:startup:browser
 
       - name: Performance (Electron)
         shell: bash
-        run: xvfb-run yarn performance:startup:electron
+        run: xvfb-run npm run performance:startup:electron
 
       - name: Analyze performance results
         uses: benchmark-action/github-action-benchmark@fd31771ce86cc65eab85653da103f71ab1b4479c # v1.9.0

diff --git a/.github/workflows/playwright.yml b/.github/workflows/playwright.yml
@@ -42,22 +42,22 @@ jobs:
       - name: Build Browser
         shell: bash
         run: |
-          yarn global add node-gyp
-          yarn --skip-integrity-check --network-timeout 100000
-          yarn download:plugins
-          yarn browser build
+          npm install -g node-gyp
+          npm ci
+          npm run build:browser
+          npm run download:plugins
         env:
           NODE_OPTIONS: --max_old_space_size=4096
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # https://github.com/microsoft/vscode-ripgrep/issues/9
 
       - name: Build Playwright
         shell: bash
         run: |
-          yarn --cwd examples/playwright build
+          cd examples/playwright && npm run build
 
       - name: Test (playwright)
         shell: bash
-        run: yarn --cwd examples/playwright ui-tests-ci
+        run: cd examples/playwright && npm run ui-tests-ci
 
       - name: Archive test results
         uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 #v4

diff --git a/.github/workflows/production-smoke-test.yml b/.github/workflows/production-smoke-test.yml
@@ -34,18 +34,18 @@ jobs:
       - name: Build Browser Example Application for Production
         shell: bash
         run: |
-          yarn global add node-gyp
-          yarn --skip-integrity-check --network-timeout 100000
-          yarn browser build:production
+          npm install -g node-gyp
+          npm ci
+          cd examples/browser && npm run build:production
         env:
           NODE_OPTIONS: --max_old_space_size=4096
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # https://github.com/microsoft/vscode-ripgrep/issues/9
 
       - name: Build Playwright
         shell: bash
         run: |
-          yarn --cwd examples/playwright build
+          cd examples/playwright && npm run build
 
       - name: Run Smoke Test (examples/playwright/src/tests/theia-app)
         shell: bash
-        run: yarn test:playwright theia-app
+        run: npm run test:playwright -- theia-app
diff --git a/.github/workflows/publish-gh-pages.yml b/.github/workflows/publish-gh-pages.yml
@@ -35,15 +35,16 @@ jobs:
 
       - name: Pre-npm-Publish
         run: |
-          yarn global add node-gyp
-          yarn --skip-integrity-check --network-timeout 100000
+          npm install -g node-gyp
+          npm ci
+          npm run build
         env:
           NODE_OPTIONS: --max_old_space_size=4096
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # https://github.com/microsoft/vscode-ripgrep/issues/9
 
       - name: Pre-docs-Publish
         run: |
-          yarn docs
+          npm run docs
         env:
           NODE_OPTIONS: --max_old_space_size=14336
 
@@ -61,7 +62,7 @@ jobs:
           retry_wait_seconds: 30
           max_attempts: 3
           retry_on: error
-          command: yarn publish:next
+          command: npm run publish:next
           on_retry_command: git reset --hard
         env:
           NPM_CONFIG_PROVENANCE: "true"

diff --git a/.github/workflows/publish-next.yml b/.github/workflows/publish-next.yml
@@ -32,16 +32,17 @@ jobs:
       - name: Install
         shell: bash
         run: |
-          yarn global add node-gyp
-          yarn --skip-integrity-check --network-timeout 100000
+          npm install -g node-gyp
+          npm ci
+          npm run build
         env:
           NODE_OPTIONS: --max_old_space_size=4096
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # https://github.com/microsoft/vscode-ripgrep/issues/9
 
       - name: Publish NPM
         shell: bash
         run: |
-          yarn publish:next
+          npm run publish:next
         env:
           NPM_CONFIG_PROVENANCE: "true"
           NODE_AUTH_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}
diff --git a/.github/workflows/publish-release.yml b/.github/workflows/publish-release.yml
@@ -38,17 +38,18 @@ jobs:
       - name: Install
         shell: bash
         run: |
-          yarn global add node-gyp
-          yarn --skip-integrity-check --network-timeout 100000
+          npm install -g node-gyp
+          npm ci
+          npm run build
         env:
           NODE_OPTIONS: --max_old_space_size=4096
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # https://github.com/microsoft/vscode-ripgrep/issues/9
 
       - name: Publish NPM
         shell: bash
         run: |
-          yarn publish:latest -- ${{ inputs.release_type }}
-          yarn publish:check
+          npm run publish:latest -- ${{ inputs.release_type }}
+          npm run publish:check
         env:
           NPM_CONFIG_PROVENANCE: "true" # enable provenance check
           NODE_AUTH_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}

diff --git a/.github/workflows/translation.yml b/.github/workflows/translation.yml
@@ -26,8 +26,9 @@ jobs:
       - name: Install and Build
         shell: bash
         run: |
-          yarn global add node-gyp
-          yarn --skip-integrity-check --network-timeout 100000
+          npm install -g node-gyp
+          npm ci
+          npm run build
         env:
           NODE_OPTIONS: --max_old_space_size=4096
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # https://github.com/microsoft/vscode-ripgrep/issues/9

diff --git a/.gitpod.dockerfile b/.gitpod.dockerfile
@@ -21,6 +21,5 @@ ENV NODE_VERSION="18.17.0"
 RUN bash -c ". .nvm/nvm.sh \
     && nvm install $NODE_VERSION \
     && nvm use $NODE_VERSION \
-    && nvm alias default $NODE_VERSION \
-    && npm install -g yarn"
+    && nvm alias default $NODE_VERSION 
 ENV PATH=$HOME/.nvm/versions/node/v${NODE_VERSION}/bin:$PATH
diff --git a/.gitpod.yml b/.gitpod.yml
@@ -12,10 +12,10 @@ ports:
   - port: 9339 # Node.js debug port
     onOpen: ignore
 tasks:
-  - init: yarn --network-timeout 100000 && yarn browser build && yarn download:plugins
+  - init: npm ci && npm run build  && npm run download:plugins
     command: >
       jwm &
-      yarn browser start ../.. --hostname=0.0.0.0
+      npm run start:browser ../.. --hostname=0.0.0.0
 vscode:
   extensions:
     - dbaeumer.vscode-eslint
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -31,7 +31,7 @@
   "lcov.watch": [
     {
       "pattern": "**/*.spec.ts",
-      "command": "yarn test:theia"
+      "command": "npm run test:theia"
     }
   ],
   "editor.insertSpaces": true,

diff --git a/.yarnrc b/.yarnrc
diff --git a/configs/base.eslintrc.json b/configs/base.eslintrc.json
@@ -12,7 +12,10 @@
     "@typescript-eslint",
     "@typescript-eslint/tslint",
     "import",
-    "no-null"
+    "no-null",
+    "eslint-plugin-deprecation",
+    "eslint-plugin-react",
+    "eslint-plugin-no-unsanitized"
   ],
   "env": {
     "browser": true,

diff --git a/dependency-check-baseline.json b/dependency-check-baseline.json
@@ -3,5 +3,8 @@
   "npm/npmjs/-/inversify/6.1.3": "Manually approved",
   "npm/npmjs/@inversifyjs/common/1.3.2": "Manually approved",
   "npm/npmjs/@inversifyjs/core/1.3.3": "Manually approved",
-  "npm/npmjs/@inversifyjs/reflect-metadata-utils/0.2.2": "Manually approved"
+  "npm/npmjs/@inversifyjs/reflect-metadata-utils/0.2.2": "Manually approved",
+  "npm/npmjs/-/plugin-a/1.55.0": "internal",
+  "npm/npmjs/-/plugin-b/1.55.0": "internal",
+  "npm/npmjs/-/plugin-gotd/1.55.0": "internal"
 }
diff --git a/dev-packages/application-manager/src/application-process.ts b/dev-packages/application-manager/src/application-process.ts
@@ -43,7 +43,8 @@ export class ApplicationProcess {
     }
 
     canRun(command: string): boolean {
-        return fs.existsSync(this.resolveBin(command));
+        const binPath = this.resolveBin(this.binProjectPath, command);
+        return !!binPath && fs.existsSync(binPath);
     }
 
     run(command: string, args: string[], options?: cp.SpawnOptions): Promise<void> {
@@ -52,16 +53,29 @@ export class ApplicationProcess {
     }
 
     spawnBin(command: string, args: string[], options?: cp.SpawnOptions): cp.ChildProcess {
-        const binPath = this.resolveBin(command);
+        const binPath = this.resolveBin(this.binProjectPath, command);
+        if (!binPath) {
+            throw new Error(`Could not resolve ${command} relative to ${this.binProjectPath}`);
+        }
         return this.spawn(binPath, args, {
             ...options,
             shell: true
         });
     }
 
-    protected resolveBin(command: string): string {
-        const commandPath = path.resolve(this.binProjectPath, 'node_modules', '.bin', command);
-        return process.platform === 'win32' ? commandPath + '.cmd' : commandPath;
+    protected resolveBin(rootPath: string, command: string): string | undefined {
+        let commandPath = path.resolve(rootPath, 'node_modules', '.bin', command);
+        if (process.platform === 'win32') {
+            commandPath = commandPath + '.cmd';
+        }
+        if (fs.existsSync(commandPath)) {
+            return commandPath;
+        }
+        const parentDir = path.dirname(rootPath);
+        if (parentDir === rootPath) {
+            return undefined;
+        }
+        return this.resolveBin(parentDir, command);
     }
 
     protected promisify(command: string, p: cp.ChildProcess): Promise<void> {