Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency on ctx in app file #23

Merged
merged 1 commit into from
Nov 6, 2019
Merged

Conversation

janchochol
Copy link
Contributor

Otherwise, it is not included in release of applications dependeing on
grpcbox.

Otherwise, it is not included in release of applications dependeing on
grpcbox.
@fenollp
Copy link

fenollp commented Nov 6, 2019

From the code (the way generated code checks whether an argument is #ctx I think this was on purpose, leaving the choice of context implementation to the user.

But I agree this should at least be added to the interop example app in this repo, just so that it's easier for newcomers to start using grpcbox ;)

@tsloughter
Copy link
Owner

Yea, I'll merge this. I have alternate plans for ctx going forward and that argument will likely be removed and the process dictionary used instead.

Once I separate out the context from the opentelemetry-erlang tracer open-telemetry/oteps#42

@janchochol
Copy link
Contributor Author

I do not think, that using ctx is somehow optional - e.g. grpcbox_client_stream:metadata_headers/1 does expect ctx module.

@tsloughter tsloughter merged commit 0fdbbd4 into tsloughter:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants