Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streaming interceptor that runs on end of stream #3

Open
tsloughter opened this issue Jun 29, 2018 · 0 comments
Open

Streaming interceptor that runs on end of stream #3

tsloughter opened this issue Jun 29, 2018 · 0 comments
Labels
enhancement

Comments

@tsloughter
Copy link
Owner

Related to #2.

Right now the interceptor is only run when the user calls a grpcbox_client:recv_ function. This breaks the functionality of interceptors like opencensus that rely on the time difference to report span duration and metrics.

Maybe keeping those metrics and exposing them to interceptors would work or have the intercepts run in the stream process, which may come out of #2.
sebastiw pushed a commit to sebastiw/grpcbox that referenced this issue Dec 10, 2020
@kjh-wg2
Merge pull request tsloughter#3 from omnicate/add_send_error
c43b421 
Add unary_error function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tsloughter