Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node 20 #167

Merged
merged 29 commits into from
Apr 5, 2024
Merged

Update node 20 #167

merged 29 commits into from
Apr 5, 2024

Conversation

tsickert
Copy link
Owner

@tsickert tsickert commented Apr 5, 2024 •
edited
Loading

  • Updates the version of node to the LTS (20)
  • Adds the excellent wait addition by @ILikePlayingGames and makes it the default since knowing the webhook succeeded is a sensible default (hence the major version change)
  • Project source file restructuring to allow for easier testing outside of actions runs
  • Fixed some longstanding typos

ILikePlayingGames and others added 29 commits March 17, 2023 05:15
@ILikePlayingGames
Implement wait
bbd23c3
@tsickert
Update node to v20
29f9976
@tsickert
Fixes for upgrade
f4badf5
@tsickert
Trying a few fixes
c5be16b
@tsickert
Throw the exception
6ba8aab
@tsickert
Try different form data method
f52e861
@tsickert
Fix tests
e0b020e
@tsickert
Try listening for error for additional information about failure
f96b971
@tsickert
Try destroying the response?
715e8e1
@tsickert
Try using axios
8b0595b
@tsickert
Attempt to use webhook
0f88348
@tsickert
Fix blob
4c21ae0
@tsickert
Try new build with fixes
8053f28
@tsickert
Update to module
eb07d27
@tsickert
Add new lib for webhook
6fb014f
@tsickert
Trivial test
d051f84
@tsickert
Config + license updates
3ea4c3d
@tsickert
Renamed entry point
09a215a
@tsickert
Change out dir ignore
2bf3c45
@tsickert
Dist
0fe8eec
@tsickert
Version bump
76567d4
@tsickert
Merge remote-tracking branch 'origin/tsickert/update-node-20' into ts…
f72e1de 
…ickert/update-node-20

# Conflicts:
#	dist/index.js
#	dist/index.js.map
#	package-lock.json
#	package.json
#	src/action.ts
@tsickert
Name blob
1ffc2fc
@tsickert
Correctly name with filename and not path
5a06f51
@tsickert
Add wait support
94d1bb3
@tsickert
Set default value of wait to true
45c484f
@tsickert
Fix typo
7bedade
@tsickert
Adjust test for wait since we wait by default now
6c05119
@tsickert
Use current build of the action for the filtered webhook example
54e44f8
@tsickert tsickert merged commit ba39ddf into master Apr 5, 2024
10 checks passed
@tsickert tsickert deleted the tsickert/update-node-20 branch April 5, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsickert @ILikePlayingGames