Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New context kb-macro.active #133

Closed
7 of 8 tasks
tshino opened this issue Aug 1, 2022 · 1 comment
Closed
7 of 8 tasks

New context kb-macro.active #133

tshino opened this issue Aug 1, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@tshino
Copy link
Owner

tshino commented Aug 1, 2022

I'm going to introduce a new Boolean context kb-macro.active which indicates that wrapper keybindings are enabled.

Currently, the context used on wrapper keybindings is kb-macro.recording which indicates that the recording is ongoing.
It means that unless the user starts a recording macro the wrapper keybindings won't be activated.
Although that is true by the design of this extension, the two concepts could be separated.
And it turned out that the two concepts must be separated to realize a new feature.
The new feature which needs the new context to be introduced is #125.

The plan is as follows:

  1. Introduce kb-macro.active as an alias of kb-macro.recording.
  2. Publish a new version. This is to mitigate the dependency issue between the binary and the document.
  3. Update the document to describe users should use kb-macro.active instead of kb-macro.recording on wrapper keybindings.
  4. Update the scripts that generate wrapper keybindings to use kb-macro.active instead of kb-macro.recording.
  5. Update the wrapper keybindings in package.json by running the updated script.
  6. Update the keymap wrappers by running the updated script.
  7. Update CHANGELOG
  8. (optional) Publish a new version.

These changes are not meant to be a breaking change for existing users.
If an existing user doesn't notice this change and even updates this extension to the new version, no noticeable change should happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant