Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate ACDD and IOOS standards #35

Merged
merged 10 commits into from
Oct 11, 2023
Merged

Incorporate ACDD and IOOS standards #35

merged 10 commits into from
Oct 11, 2023

Conversation

jmcvey3
Copy link
Contributor

@jmcvey3 jmcvey3 commented Oct 10, 2023

Update template so that users can choose a specific standards type, which is then automatically set up in the generated ingest pipeline. Also updates basic tsdat template to set CF time attributes.

Left to do:

  • Fix relative import for windows so "make cookies" will work
  • Set default standards to "basic"

Copy link
Contributor

@maxwelllevin maxwelllevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested for how we approach the schema generation (noted in review comments). The main thing is just that I think we should generate the IOOS/ACDD/basic schema once and from then on we should just default to using that schema, instead of doing this for each new ingest we generate.

I can tell a lot of work went in to the updated template, especially in the wording / description of all the attributes. I think this is a massive improvement over what we currently have, so I'm looking forward to merging these changes in.

.vscode/settings.json Show resolved Hide resolved
templates/generate.py Show resolved Hide resolved
templates/generate.py Outdated Show resolved Hide resolved
utils/schemas.py Outdated Show resolved Hide resolved
utils/schemas.py Outdated Show resolved Hide resolved
@maxwelllevin
Copy link
Contributor

Changes requested for how we approach the schema generation (noted in review comments). The main thing is just that I think we should generate the IOOS/ACDD/basic schema once and from then on we should just default to using that schema, instead of doing this for each new ingest we generate.

I changed my mind on the details for this. I think we should add these schemas to the core tsdat library and allow users to select which one they'd like to use when the tsdat generate_schema CLI is invoked. I'll add those changes to tsdat/tsdat#139

@maxwelllevin
Copy link
Contributor

@jmcvey3 merge at-will

@jmcvey3 jmcvey3 merged commit a8d191b into main Oct 11, 2023
2 checks passed
@jmcvey3 jmcvey3 deleted the new_schema branch October 11, 2023 23:55
maxwelllevin added a commit that referenced this pull request Oct 24, 2023
* A start

* Progress

* File to generate schema

* Update schema defs

* Fix schema

* Cleanup

* Fix tests

* Revert a couple changes

* Typer tool and typo fixes

* More schema generation to core tsdat

Co-authored-by: James McVey <[email protected]>

---------

Co-authored-by: Maxwell Levin <[email protected]>
maxwelllevin added a commit that referenced this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants