-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate ACDD and IOOS standards #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested for how we approach the schema generation (noted in review comments). The main thing is just that I think we should generate the IOOS/ACDD/basic schema once and from then on we should just default to using that schema, instead of doing this for each new ingest we generate.
I can tell a lot of work went in to the updated template, especially in the wording / description of all the attributes. I think this is a massive improvement over what we currently have, so I'm looking forward to merging these changes in.
templates/ingest/{{ cookiecutter.module }}/config/dataset-basic.yaml
Outdated
Show resolved
Hide resolved
templates/ingest/{{ cookiecutter.module }}/config/dataset-basic.yaml
Outdated
Show resolved
Hide resolved
I changed my mind on the details for this. I think we should add these schemas to the core tsdat library and allow users to select which one they'd like to use when the |
Co-authored-by: James McVey <[email protected]>
@jmcvey3 merge at-will |
* A start * Progress * File to generate schema * Update schema defs * Fix schema * Cleanup * Fix tests * Revert a couple changes * Typer tool and typo fixes * More schema generation to core tsdat Co-authored-by: James McVey <[email protected]> --------- Co-authored-by: Maxwell Levin <[email protected]>
This reverts commit 4cb070f.
Update template so that users can choose a specific standards type, which is then automatically set up in the generated ingest pipeline. Also updates basic tsdat template to set CF time attributes.
Left to do: