Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ember]: set skipLibCheck: true #269

Merged
merged 1 commit into from
May 22, 2024

Conversation

NullVoxPopuli
Copy link
Contributor

see comments

@wagenet wagenet merged commit aebb598 into tsconfig:main May 22, 2024
1 check passed
@voxpelli
Copy link

Do be aware that this also deactivates checks for all *.d.ts files within your own project as well, see eg: sindresorhus/tsconfig#15

@NullVoxPopuli
Copy link
Contributor Author

Yeah, i've been debating making a new 'bases' config for libraries, as we already diverge quite a bit:

https://github.com/embroider-build/addon-blueprint/blob/main/files/__addonLocation__/tsconfig.json

If added to tsconfig/bases, i'm not sure what to call it.

Maybe v2-addon.json? Thoughts?

It's another question tho if our community wants skipLibCheck turned on for library authoring by default, or if we want opt-in good-stewardship. Idk

@NullVoxPopuli NullVoxPopuli deleted the skipLibCheck-types-note-update branch May 24, 2024 12:07
@voxpelli
Copy link

@NullVoxPopuli To me as a JSDoc / types in js user it's less about being a library or not, my projects often look like this no matter of they are libraries or not: https://github.com/voxpelli/list-dependents/tree/main/lib

Skärmavbild 2024-05-24 kl  15 27 21

This as type declarations files enable some things that is hard or verbose to do in JSDoc.

I also find that type-only .ts-files are better written as .d.ts files, as that indicate that they are type only. But skipLibCheck discourages that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants