Fix session key handling #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stucki
commented
Oct 12, 2017
stucki
commented
- Fix user creation (how could this work at all before?!)
- Improve Shibboleth session key extraction (make it more readable)
- Improve key search (stop search after first match)
- Cleanup
stucki
force-pushed
the
fix-session-key-handling
branch
from
e76b388 to
d90d589
Compare
|
@tschikarski Any feedback on this? |
stucki
force-pushed
the
fix-session-key-handling
branch
from
d90d589 to
2e49d04
Compare
|
Comment on previous status change: The commit referenced is wrong. However, I assume this issue resolved by the now uploaded version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.