config: include --nojekyll option flag #468
Conversation
config: cname flag
|
This flag would be really convenient. Although, I solved it by manually adding the |
|
The author doesn't seem to be maintaining the package anymore, what I did is I went ahead and created my own fork of the library and use it from there. |
|
This would be a tremendous asset to this plugin. @tschaub could you please get this reviewed and merged? |
| @@ -113,6 +116,14 @@ exports.publish = function publish(basePath, config, callback) { | |||
| return; | |||
| } | |||
|
|
|||
| if (options.cname) { | |||
| fs.writeFileSync(path.join(basePath, 'CNAME'), options.cname); | |||
| } | |||
There was a problem hiding this comment.
I think this will result in the CNAME file being written to the dest directory (which may be a subdirectory not at the root of the repo). I think it should be written to the root instead.
|
|
||
| if (options.nojekyll) { | ||
| fs.createFileSync(path.join(basePath, '.nojekyll')); | ||
| } |
There was a problem hiding this comment.
Same above as above about writing to the dest directory instead of the root. In addition, won't this file be ignored unless the --dotfiles option is also specified?
No description provided.