Feat/open ports on anythink ack #39
Conversation
.framework/java/docker-compose.yml
Outdated
| container_name: anythink-ack | ||
| command: sh -c "/wait-for-it.sh anythink-frontend-react:3001 -q -t 1000 && ./anythink_ack.sh" | ||
| environment: | ||
| - GITHUB_TOKEN=$GITHUB_TOKEN | ||
| - CODESPACE_NAME=$CODESPACE_NAME | ||
| working_dir: /usr/src | ||
| volumes: | ||
| - ./:/usr/src/ |
There was a problem hiding this comment.
just wondering now, does it actually requires the whole file tree? would it work if it had only the open_port.sh script?
Also maybe we don't care about it having the while tree if it loads quickly
There was a problem hiding this comment.
I can move the anythink_ack and open ports scripts to be inside the image... and then remove the volume, I can do it after if
There was a problem hiding this comment.
No biggy just a thought I had. No real opinion about wether it worth it
There was a problem hiding this comment.
I think it'll just be nicer to have everything in the image, but that can wait
There was a problem hiding this comment.
I did it here - https://github.com/trywilco/Anythink-Market-Docker-Images/pull/11 i'll change this PR accordingly
| COPY backend ./backend | ||
| COPY .wilco ./.wilco | ||
|
|
||
| # Pre-install npm packages |
Description
Change the ports visibility to public to avoid CORS issues, when the anythink services are ready.
It seems that changing the ports before the services start doesn't always work, but do work when the services are listening to a port.
Added also missing AWS image on the java folder.