[UX Improvement] Search! #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial stab at implementing search. There are some issues to be aware of as of right now: - using '/' in search will break due to the way we grab the query from the `pathname` variable - `closeOnClick` for search IconButton tooltip - make search IconButton unstyled and larger (peep Pocket) - (more BE than anything) ensure queries are somewhat efficient and look into utilizing indices for performance optimizations - …and other stuff I'm forgetting the moment It's a great start nonetheless. Thinking users will be excited to have this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial stab at implementing search. There are some issues to be aware of as of right now:
closeOnClickfor search IconButton tooltipmake search IconButton unstyled and larger (peep Pocket)the
pathnamevariableinto utilizing indices for performance optimizations
It's a great start nonetheless. Thinking users will be excited to have this!