-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type hints and changes to class inheritance #76
Open
bmos
wants to merge
33
commits into
tryolabs:master
Choose a base branch
from
bmos:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
really appreciate the contributions @bmos! I inherited this project a few years back and haven't had the time to give it the love it deserves. Will do some testing when I get time (hopefully in the next few weeks). |
bmos
force-pushed
the
master
branch
16 times, most recently
from
February 29, 2024 16:53
ef9a06d
to
d4c8c28
Compare
bmos
force-pushed
the
master
branch
2 times, most recently
from
March 1, 2024 01:59
2e3e60f
to
df3db34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes from the MixIn pattern to direct inheritance (since it only inherits from one class) and adds type hints to pretty much every arg and return. Since the MixIn was not combining many classes, this should work just as well and it's better supported by the 'magic' of modern IDEs.
It passes the limited pytest implementation, but I'm not so familiar with this module and it's quite likely that this could break things. So I'd advise against merging it without doing at least some basic tests yourself.
I tried to keep most of these commits standalone so it shouldn't be too hard to skip some of them if they're too opinionated, although once I split it into multiple files it probably gets harder to piecemeal it.