-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lmeval): Send Job logs to Pod StdOut #358
fix(lmeval): Send Job logs to Pod StdOut #358
Conversation
PR image build and manifest generation completed successfully! 📦 PR image: 📦 LMES driver image: 📦 LMES job image: 🗂️ CI manifests
|
@RobGeada: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this Rob. So the problem is the output pipe. I thought it was the scanner.
|
||
// carriage returns do not correctly display, so replace with newlines | ||
// carriage returns also break the pipewriter, so make sure we get newlines as well. | ||
if strings.ContainsAny(line, "\r") && !strings.ContainsAny(line, "\n") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am thinking would it be more straightforward to directly do a regexp.ReplaceAll()
for all incoming []byte i.e:
re := regexp.MustCompile(`(?m)\r[^\n]`)
updatedBytes := re.ReplaceAll(p, []byte("\n"))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good to me
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ruivieira, yhwang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.