Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lmeval): Send Job logs to Pod StdOut #358

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

RobGeada
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Nov 11, 2024

PR image build and manifest generation completed successfully!

📦 PR image: quay.io/trustyai/trustyai-service-operator-ci:31bf02184e9cea97b9d656b446a08ccbba5eb9c0

📦 LMES driver image: quay.io/trustyai/ta-lmes-driver:31bf02184e9cea97b9d656b446a08ccbba5eb9c0

📦 LMES job image: quay.io/trustyai/ta-lmes-job:31bf02184e9cea97b9d656b446a08ccbba5eb9c0

🗂️ CI manifests

devFlags:
  manifests:
    - contextDir: config
      sourcePath: ''
      uri: https://api.github.com/repos/trustyai-explainability/trustyai-service-operator-ci/tarball/operator-31bf02184e9cea97b9d656b446a08ccbba5eb9c0

Copy link

openshift-ci bot commented Nov 11, 2024

@RobGeada: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/trustyai-service-operator-e2e 4cfaac9 link true /test trustyai-service-operator-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Collaborator

@yhwang yhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this Rob. So the problem is the output pipe. I thought it was the scanner.

controllers/lmes/driver/driver.go Show resolved Hide resolved

// carriage returns do not correctly display, so replace with newlines
// carriage returns also break the pipewriter, so make sure we get newlines as well.
if strings.ContainsAny(line, "\r") && !strings.ContainsAny(line, "\n") {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking would it be more straightforward to directly do a regexp.ReplaceAll() for all incoming []byte i.e:

re := regexp.MustCompile(`(?m)\r[^\n]`)
updatedBytes := re.ReplaceAll(p, []byte("\n"))

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yhwang I've opened #359 so this could be done on a separate PR after this one is tested, if that's ok.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good to me

@openshift-ci openshift-ci bot added the lgtm label Nov 11, 2024
@ruivieira ruivieira linked an issue Nov 11, 2024 that may be closed by this pull request
@openshift-ci openshift-ci bot removed the lgtm label Nov 12, 2024
@ruivieira ruivieira changed the title Send Job logs to Pod StdOut fix(lmeval): Send Job logs to Pod StdOut Nov 12, 2024
Copy link

openshift-ci bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ruivieira, yhwang

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ruivieira ruivieira merged commit 2a8f7d7 into trustyai-explainability:main Nov 12, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Occasional LM-Eval job freeze
3 participants