-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-15105: Add offline support for LMEvalJobs #351
RHOAIENG-15105: Add offline support for LMEvalJobs #351
Conversation
@ruivieira: This pull request references RHOAIENG-15105 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
PR image build and manifest generation completed successfully! 📦 PR image: 📦 LMES driver image: 📦 LMES job image: 🗂️ CI manifests
|
@ruivieira: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
While reviewing the code, it reminded me of one thing not directly related to this change. I believe it would be good to create an issue regarding enabling the validation webhook for LMES controller. Then we can enable some tedious value checking there.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yhwang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Refers to RHOAIENG-15105.
Add support for offline flags in the
LMEvalJob
container and mount PVC containing models and datasets.If the optional
offline
field is set:offline mode will be enabled. If it is missing, offline mode will be disable.