-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Firo]: Support exchange address #3712
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w20089527
requested review from
Milerius,
satoshiotomakan and
lamafab
as code owners
March 5, 2024 09:29
satoshiotomakan
requested changes
Mar 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @w20089527, thank you for opening the PR!
…exchange address
…WAnyAddressCreateWithPublicKeyFiroExchangeAddress`
satoshiotomakan
approved these changes
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix! LGTM
I have one suggestion in case if you need to support testnet addresses
Milerius
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A new address for exchange requirement.
As exchange address has same unlocking script with regular address(p2pkh), our work will involve as following:
derive
of this addressvalidation
of this addressOP_EXCHANGEADDR
FYI: as we do not have any config in
registry.json
for this kind of address, I defined aExchangeAddress
with constants that only works formainnet
, if want to supporttestnet
orregtest
, we need to define corresponding class for them.Check here for exchange address description:
https://github.com/firoorg/firo/wiki/Exchange-Addresses
Here is the detail pr for exchange address:
firoorg/firo#1356
How to test
Testcases added for this feature
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
If you're adding a new blockchain