Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix recipient aid references #183

Closed

Conversation

lenkan
Copy link

@lenkan lenkan commented Jun 26, 2024

I believe there were some missing updates from this commit: 914f6e5

Copy link

CLA Not Signed

@daidoji
Copy link
Contributor

daidoji commented Jul 14, 2024

Yeah something weird happened here because I see Sam's fix on 1082 previous from that commit didn't make it either. Also there's a typo in https://trustoverip.github.io/tswg-keri-specification/#controller-aid-field A Receiver AID, ~i~ri field MAY appear in other places in messages. In those cases, its meaning SHOULD be determined by the context of its appearance

Also, I was going to push a PR but the "ri" field information is now very confusing because we have that quote with the typo saying "ri" MAY appear in that section, but then in the rest of the query messages we have that All are REQUIRED. No other top-level fields are allowed (MUST NOT appear) so its unclear how that field should be used.

#199 to track.

@SmithSamuelM
Copy link
Contributor

Fixed with #200

@SmithSamuelM
Copy link
Contributor

Fixed with #200

@daidoji
Copy link
Contributor

daidoji commented Jul 16, 2024

@SmithSamuelM that fixes the issue with my particular comment and I've updated my associated issue, but I think @lenkan's other changes are still needed from this PR. There's some ambiguity in how the ri field is used without the edits from his PR.

@SmithSamuelM
Copy link
Contributor

SmithSamuelM commented Jul 16, 2024

I believe all the examples now include the "ri" field and the description of fields also. So I am not seeing that they are missing.

See #202

@daidoji
Copy link
Contributor

daidoji commented Jul 16, 2024

@SmithSamuelM Roger on that PR. Actually, I see where the miscommunication arises. You're correct that ri does seem to exist in all the examples. In each section though there's a list of fields like The top-level fields of an Exchange, exn message body MUST appear in the following order: [ v, t, d, i, x, p, dt, r, q, a]. All are REQUIRED. No other top-level fields are allowed (MUST NOT appear).

The ri field is missing from all of these lists and the wording makes it seem like this field can't exist in any of those events. See #199.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants