This repository has been archived by the owner on Aug 25, 2023. It is now read-only.
fix: GNAP header inspection bug #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #321 +/- ##
==========================================
+ Coverage 86.26% 86.30% +0.03%
==========================================
Files 26 26
Lines 2133 2139 +6
==========================================
+ Hits 1840 1846 +6
Misses 182 182
Partials 111 111
Continue to review full report at Codecov.
|
DRK3
force-pushed
the
FixGNAPMiddlewareHeaderLogic
branch
from
ee77113 to
fa0ee57
Compare
fqutishat
approved these changes
Jul 18, 2022
The GNAP middleware's Accept method checks each value in the Authorization header slice and if any of them contain a GNAP token, then the middleware handles it. However, the middleware Handle method then uses the Header.Get method, which always gets the first value from the Header slice. Thus, if a request comes in with a GNAP token in the Authorization header but in any value but the first, the handler will accept it but then fail to handle it since it will miss the token. Also updated code that access headers to use the built-in Header methods to retrieve the values (instead of directly accessing the map) since they ensure that values are canonicalized. Signed-off-by: Derek Trider <[email protected]>
DRK3
force-pushed
the
FixGNAPMiddlewareHeaderLogic
branch
from
fa0ee57 to
471fd63
Compare
aholovko
approved these changes
Jul 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GNAP middleware's Accept method checks each value in the Authorization header slice and if any of them contain a GNAP token, then the middleware handles it. However, the middleware Handle method then uses the Header.Get method, which always gets the first value from the Header slice. Thus, if a request comes in with a GNAP token in the Authorization header but in any value but the first, the handler will accept it but then fail to handle it since it will miss the token.
Also updated code that access headers to use the built-in Header methods to retrieve the values (instead of directly accessing the map) since they ensure that values are canonicalized.
Signed-off-by: Derek Trider [email protected]