Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPF for primary domain #120

Closed
lleger opened this issue May 13, 2022 · 2 comments
Closed

SPF for primary domain #120

lleger opened this issue May 13, 2022 · 2 comments
Assignees

Comments

@lleger
Copy link

lleger commented May 13, 2022

Hi!

This module creates two SPF records, one for the mail from domain and one for the apex (root) domain. I know there's an option to turn this off, but it turns both off, so you still have to manually manage at least the mail from domain.

But my question is: why is this module making SPF records for the apex domain? As far as I can tell, this isn't required by SES. See below for the record set from the console:
CleanShot 2022-05-13 at 14 17 55@2x

@esacteksab
Copy link
Contributor

esacteksab commented Nov 16, 2022

Looking at the docs it makes no mention of an SPF record for the apex or root domain. But looking further it does mention creating both an MX record along with a TXT record for the SPF record. This is further supported by Terraform's documentation. I believe I have captured your request this PR. If I didn't, please let me know. Thank you!

@lleger
Copy link
Author

lleger commented Dec 28, 2022

Thank you that is a perfect fix.

rpdelaney added a commit that referenced this issue Jan 13, 2023
Fixes #120 by ensuring a single SPF record is created
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants