HOLD: Support for guardduty exports #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjdufour-dds
force-pushed
the
guardduty_new_version
branch
from
a0e7e3a
to
bfcbb51
Compare
dynamike
suggested changes
Apr 10, 2020
|
I'll try to get to this next week. |
|
Added a test. Since GuardDuty exports still need to be manually configured, not sure if more is required for the test. hashicorp/terraform-provider-aws#10920 |
pjdufour-dds
force-pushed
the
guardduty_new_version
branch
from
3a9e757
to
d614b3c
Compare
|
Rebased with master |
|
It looks like they added support for exports via terraform. Could you update your tests to use it? |
Closed
|
Holding for #60 |
pjdufour-dds
changed the title
pjdufour-dds
force-pushed
the
guardduty_new_version
branch
from
d614b3c
to
e698b81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes support for GuardDuty logs. I also added some comments to the source code on why the paths are what they are. Now sure where you'd like those to be located.