Add support for associating an ECS service with a NLB. #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjdufour-truss
approved these changes
Sep 12, 2018
brainsik
suggested changes
Sep 12, 2018
main.tf
Outdated
| "protocol": "tcp" | ||
| "containerPort": 80, | ||
| "hostPort": 80, | ||
| "protocol": "tcp" |
There was a problem hiding this comment.
What's up with this weird whitespace adjustment?
main.tf
Outdated
| "awslogs-stream-prefix": "nginx" | ||
| "awslogs-group": "${local.awslogs_group}", | ||
| "awslogs-region": "${data.aws_region.current.name}", | ||
| "awslogs-stream-prefix": "nginx" |
There was a problem hiding this comment.
What's up with this weird whitespace adjustment?
There was a problem hiding this comment.
Some how tabs snuck in there
| @@ -308,7 +346,7 @@ locals { | |||
| } | |||
|
|
|||
| resource "aws_ecs_service" "main" { | |||
| count = "${var.associate_lb}" | |||
| count = "${var.associate_alb || var.associate_nlb ? 1 : 0}" | |||
There was a problem hiding this comment.
Does this really need the ? 1: 0? These are both bools. I think it makes it extra clear this is different from the one below.
There was a problem hiding this comment.
I get cannot parse "true" as an integer if I'm not being explicit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allows the ECS service to register with a Network Load Balancer's target group. I also modified the
associate_lbvariable to be split intoassociate_albandassociate_nlb. NLBs don't have security groups so this PR will allow the ingress from the NLB's subnets to the ECS containers.I'll release
v1.9.0once this PR merges.