feat: Add all component prop type definitons as exports #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a wrapper that extends a uswds component, it is useful to import in the Props that the wrapped component has so that the wrapped component’s prop types can be extended rather than having to copy and paste them. To allow this, I am adding exports for all Props type definitions. This shouldn’t have any impact on any projects that use react-uswds.
|
Thanks @RobKohr! Take a look at the existing issue for this change; there might be a few more considerations before we can call it done. |
brandonlenz
changed the title
@RobKohr I'd love to get this merged in the next release if you have some time to review the above. Do you need any help? |
|
Is any help needed on this? I'd be happy to offer my assistance. I'm working on a new project for work and would really like to have this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a wrapper that extends a uswds component, it is useful to import in the Props that the wrapped component has so that the wrapped component’s prop types can be extended rather than having to copy and paste them.
To allow this, I am adding exports for all Props type definitions.
This shouldn’t have any impact on any projects that use react-uswds.
Summary
Related Issues or PRs
#2667
#2728
How To Test
Nothing should change for the use of the package, but anything importing the package should also be able to import the Props type definition for any component.