Add flag to skip clean objects #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrepiske
approved these changes
Jun 26, 2023
rpdelaney
suggested changes
Jul 18, 2023
common.py
Outdated
| @@ -43,6 +43,7 @@ | |||
|
|
|||
| AV_DEFINITION_FILE_PREFIXES = ["main", "daily", "bytecode"] | |||
| AV_DEFINITION_FILE_SUFFIXES = ["cld", "cvd"] | |||
| AV_SKIP_CLEAN_OBJECTS = os.getenv("AV_SKIP_CLEAN_OBJECTS", "False") | |||
There was a problem hiding this comment.
Suggested change
| AV_SKIP_CLEAN_OBJECTS = os.getenv("AV_SKIP_CLEAN_OBJECTS", "False") | |
| AV_SKIP_CLEAN_OBJECTS = int(os.getenv("AV_SKIP_CLEAN_OBJECTS", "0")) |
"False" is truthy. This should make it more difficult to accidentally set a truthy value. I'm definitely open to other approaches though.
There was a problem hiding this comment.
"False" would still return 0 in this case:
But I have no problems with changing the env.
Just keep in mind that it would only accept numeric values, and a "False" or "True" would raise instead.
There was a problem hiding this comment.
In python, str_to_bool isn't a built-in. Where are you getting that defined?
Co-authored-by: Ryan Delaney <[email protected]>
|
Tests please? :) @cuchi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a flag
AV_SKIP_CLEAN_OBJECTSthat allows us to skip objects that are guaranteed to be clean (i.e. server-generated files). This flag is disabled by default, so it won't disrupt any existing behavior.If the flag is enabled, it will skip the scan for every file that has the metadata
av-status:CLEAN.