watch: match on All event
#620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some platforms don't support precise notification kinds and instead report `All` as an event kind. This is what the notification system reports when it doesn't know what else to report. It's also the kind that's used in "imprecise" mode. This fixes watching on Windows, and may address issues reported in trunk-rs#232. Signed-off-by: Sean Cross <[email protected]>
Signed-off-by: Sean Cross <[email protected]>
|
There had been a bunch of fixes regarding this in |
|
I think with the merge of #623, which already contained this fix, this PR should no longer be needed. Please let me know if I missed something. |
|
Sounds good. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some platforms don't support precise notification kinds and instead report
Allas an event kind. This is what the notification system reports when it doesn't know what else to report.It's also the kind that's used in "imprecise" mode.
This fixes watching on Windows, and may address issues reported in #232.
Checklist
sitecontent with pertinent info (may not always apply).