-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ws_protocol
option
#494
Conversation
a361323
to
ae2eda1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to open this PR! I think this is a valuable changeset. A few things which I think we should do:
- Let's update the website to document this new configuration option.
- We should use an enum in the Rust code to declare the two available values, either
Ws
orWss
. - If the value is left unspecified, then this should default to the current behavior where we match the site's http/https protocol.
- In the autoreload.js, instead of checking for the interpolated
{{protocol}}
value of'auto'
, we should just interpolate an empty string if left unspecified, and then trigger the http/https matching behavior.
Thoughts?
I added all required changes except this:
The website doesn't contain all configuration options and I am not sure where to include this one, isn't it enough to include it in the example configuration file? |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Is there anything left to do before this PR can get merged? |
@amrbashir unfortunately I can't easily cherry-pick this into trunk-ng due to recent changes. If you want to rebase and raise a PR with trunk-ng, I could merge it. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
IIRC, this was already merged into |
This was brought back to trunk with PR #623 and it should be part of the next release of trunk too. |
nice, I guess I can close this now |
Checklist
site
content with pertinent info (may not always apply).Sometimes it is necessary to use
ws:
instead ofwss:
, this was encountered while working on a project for tauri (on android) where usingwss:
wasn't possible.