Added https support for `trunk serve`. #458

murosuke · 2022-11-20T17:36:28Z

This allows users to serve with https. To enable this, add path to the cert files as below in Trunk.toml. If it failed to read cert files, it will start in http as usual.

[serve]
crt = "./server.crt"
key = "./server.key"

Checklist

Updated CHANGELOG.md describing pertinent changes.
Updated README.md with pertinent info (may not always apply).
Updated site content with pertinent info (may not always apply).
Squash down commits to one or two logical commits which clearly describe the work you've done. If you don't, then Dodd will 🤓.

peteringram0 · 2022-12-04T21:01:00Z

Hi, Is there anyway to try this before it gets merged at all?

simbleau · 2023-01-04T05:46:00Z

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "trunk"
-version = "0.16.0"
+version = "0.17.0"


do not bump the version

I reverted version.

simbleau · 2023-01-04T05:47:14Z

src/serve.rs


        // Block this routine on the server's completion.
        tracing::info!("{} server listening at http://{}", SERVER, addr);
+        let server = Server::bind(&addr)


Should this come before the tracing log?

Changed comment position just before server.await.

simbleau · 2023-01-04T05:48:50Z

src/config/rt.rs

@@ -218,6 +218,10 @@ pub struct RtcServe {
    pub proxies: Option<Vec<ConfigOptsProxy>>,
    /// Whether to disable auto-reload of the web page when a build completes.
    pub no_autoreload: bool,
+    /// Path to crt file.
+    pub crt: PathBuf,


Use Option<PathBuf> or OsStr for these types

Wrapped key/crt member with Option.

simbleau · 2023-01-04T05:51:14Z

Please add an example with HTTPS, so we may test this.

murosuke · 2023-01-15T04:15:12Z

@simbleau Thankyou for reviewing. I made a sample here.
I checked in windows.

run sample as https

Create key and crt pair with openssl(without encrypt).
openssl req -x509 -new -keyout server.key -out server.crt -days 365
Place server.key and server.crt under the yew folder.
Add localhost as another domain in hosts file to prevents browsers from operating in trust mode.(Secure context WebAPI like showOpenFilePicker works with HTTP localhost, when usually should only work with HTTPS.)
127.0.0.1 server.my
- windows
  - C:\Windows\System32\drivers\etc\hosts
- linux
  - /etc/hosts
Run yew with merged trunk.
trunk serve
Access https://server.my:8080 with browser.
If it is operating successfully, opening file picker should work(this won't work when accessing http://server.my:8080 running with trunk before merge).

murosuke · 2023-01-15T04:49:01Z

@peteringram0 Sorry for the late reply.
You can clone original trunk, create branch and easly build it.
git fetch origin pull/458/head:PR-458
git checkout PR-458
cargo build
After build, trunk binary will be generated at target/target/debug/trunk.exe(I checked in windows).
Use target/target/debug/trunk.exe with project you are using trunk with.

lpotthast · 2023-03-14T07:03:38Z

Is it possible to assist here?

lpotthast · 2023-03-14T07:33:15Z

Note that this development version can also be installed using:

cargo install --git https://github.com/murosuke/trunk --branch develop trunk

lpotthast · 2023-03-18T16:50:05Z

Note: I can not close the dev-server using Ctrl-C. Is the signal correctly handled? I am using an M1 mac, Trunk config contains an active proxy section.

Also worth noting: I generated a self-signed certificate using a custom ca. That ca is part of my machines keychain. Chrome accepts the generated certificate perfectly. But: I had to set insecure = true in Trunk.tomls [[proxy]] section for communicating with my backend service (axum running in https locally using the same cert). Is Trunk using the systems CA store properly? I had not anticipated that this option would become necessary..

thedodd

One item so far, I'll finish up review on src/serve.rs shortly.

thedodd · 2023-03-22T22:36:09Z

src/config/models.rs

@@ -127,6 +127,10 @@ pub struct ConfigOptsServe {
    #[clap(long = "no-autoreload")]
    #[serde(default)]
    pub no_autoreload: bool,
+    #[clap(parse(from_os_str))]
+    pub crt: Option<PathBuf>,
+    #[clap(parse(from_os_str))]


Let's add these to an arg group to ensure that it is clear to users that both must be declared together.

rogusdev · 2023-10-01T16:44:14Z

Also worth noting: I generated a self-signed certificate using a custom ca. That ca is part of my machines keychain. Chrome accepts the generated certificate perfectly. But: I had to set insecure = true in Trunk.tomls [[proxy]] section for communicating with my backend service

Self signed certificates are officially invalid, by definition, and need insecure acceptance, for sure.

github-actions · 2023-11-16T00:37:41Z

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions · 2023-11-26T00:39:57Z

This PR was closed because it has been stalled for 10 days with no activity.

ctron · 2023-12-12T07:43:54Z

I do believe this was part of trunk-ng. With the merge of trunk-ng into trunk as part of PR #623, that should be part of the next trunk release. If that's not the case, please let us know.

Added https support for trunk serve.

ab2ed79

simbleau requested changes Jan 4, 2023

View reviewed changes

Reverted version, wrapped crt/key with Option, changed comment position.

d4a43d3

murosuke requested a review from simbleau March 18, 2023 08:18

thedodd reviewed Mar 22, 2023

View reviewed changes

lpotthast mentioned this pull request Aug 8, 2023

Add TLS support for trunk serve #532

Closed

4 tasks

github-actions bot added the Stale label Nov 16, 2023

github-actions bot closed this Nov 26, 2023

ranile mentioned this pull request Dec 6, 2023

Stop closing valid issues and pull requests #625

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added https support for `trunk serve`. #458

Added https support for `trunk serve`. #458

murosuke commented Nov 20, 2022 •

edited

Loading

peteringram0 commented Dec 4, 2022

simbleau Jan 4, 2023

murosuke Jan 15, 2023

simbleau Jan 4, 2023

murosuke Jan 15, 2023

simbleau Jan 4, 2023

murosuke Jan 15, 2023

simbleau commented Jan 4, 2023 •

edited

Loading

murosuke commented Jan 15, 2023

murosuke commented Jan 15, 2023

lpotthast commented Mar 14, 2023

lpotthast commented Mar 14, 2023

lpotthast commented Mar 18, 2023 •

edited

Loading

thedodd left a comment

thedodd Mar 22, 2023

rogusdev commented Oct 1, 2023

github-actions bot commented Nov 16, 2023

github-actions bot commented Nov 26, 2023

ctron commented Dec 12, 2023

Added https support for trunk serve. #458

Added https support for trunk serve. #458

Conversation

murosuke commented Nov 20, 2022 • edited Loading

peteringram0 commented Dec 4, 2022

simbleau Jan 4, 2023

Choose a reason for hiding this comment

murosuke Jan 15, 2023

Choose a reason for hiding this comment

simbleau Jan 4, 2023

Choose a reason for hiding this comment

murosuke Jan 15, 2023

Choose a reason for hiding this comment

simbleau Jan 4, 2023

Choose a reason for hiding this comment

murosuke Jan 15, 2023

Choose a reason for hiding this comment

simbleau commented Jan 4, 2023 • edited Loading

murosuke commented Jan 15, 2023

run sample as https

murosuke commented Jan 15, 2023

lpotthast commented Mar 14, 2023

lpotthast commented Mar 14, 2023

lpotthast commented Mar 18, 2023 • edited Loading

thedodd left a comment

Choose a reason for hiding this comment

thedodd Mar 22, 2023

Choose a reason for hiding this comment

rogusdev commented Oct 1, 2023

github-actions bot commented Nov 16, 2023

github-actions bot commented Nov 26, 2023

ctron commented Dec 12, 2023

Added https support for `trunk serve`. #458

Added https support for `trunk serve`. #458

murosuke commented Nov 20, 2022 •

edited

Loading

simbleau commented Jan 4, 2023 •

edited

Loading

lpotthast commented Mar 18, 2023 •

edited

Loading