Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rust link opts keep-debug & no-demangle. #154

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Conversation

thedodd
Copy link
Member

@thedodd thedodd commented Mar 26, 2021

These new data-* options for <link rel="rust" .../> influence the way
that Trunk invokes wasm-bindgen, invoking the --keep-debug &
--no-demangle options respectively.

closes #135

Checklist

  • Updated CHANGELOG.md describing pertinent changes.
  • Updated README.md with pertinent info (may not always apply).

@thedodd
Copy link
Member Author

thedodd commented Mar 26, 2021

@jbg let me know if this is roughly what you had in mind.

These new data-* options for <link rel="rust" .../> influence the way
that Trunk invokes wasm-bindgen, invoking the --keep-debug &
--no-demangle options respectively.

closes #135
@jbg
Copy link
Contributor

jbg commented Mar 29, 2021

@jbg let me know if this is roughly what you had in mind.

This looks great; it absolutely solves the problem from my POV!

@thedodd thedodd merged commit d3075ec into master Mar 29, 2021
@thedodd thedodd deleted the 135-keep-debug branch March 29, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow keeping debug symbols in the generated wasm output in release builds
2 participants