Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite watch loop on Windows #134

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

torhovland
Copy link

Checklist

  • Updated CHANGELOG.md describing pertinent changes.
  • Updated README.md with pertinent info (may not always apply).

Fixes #133.

@torhovland torhovland changed the title Infinite watch loop windows Infinite watch loop on Windows Feb 23, 2021
@thedodd
Copy link
Member

thedodd commented Mar 2, 2021

The thing which is a bit frustrating about this situation is that there is only one location where a value is sent over this channel, and that is just before we issue the cargo build. Also, as you can see from your diagnostics report in #133, that path is actually canonical ... except that it doesn't have the ? prefix ... is this a requirement for canonical paths on Windows?

Either way, we recently fixed a bug which was causing Trunk to crash due to the fact that the target will not always be present. So there were times when we were canonicalizing the path, and it was causing an error. Fix one bug, cause another.

So, here is what I will do. I'm going to merge your code. Once it is in, I'm going to update the ONE location in the code where a path is sent over that channel to update the ignore list, and I only going to do so AFTER the cargo build has completed successfully. That should give us our needed behavior, and we will be able to properly canonicalize the path as cargo will have created it.

@thedodd thedodd merged commit bf27965 into trunk-rs:master Mar 2, 2021
@torhovland torhovland deleted the infinite-watch-loop-windows branch March 3, 2021 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite watch loop on Windows
2 participants