Clean build previous artifacts after successful build (II) #108
Conversation
|
Have not tested on Windows yet. |
There was a problem hiding this comment.
Awesome work, @philip-peterson! Thanks for all of the effort here, and definitely shoutout to @hamza1311 for their work as well!
Just a few small things I'm requesting changes for. In addition to the line items I've specified, what do you think about updating the various context/logging statements to say "staging dir" instead of "dist/.current"? I'm just thinking that keeping it generic will help to avoid confusion if we decide to change the name of the staging dir in the future.
There was a problem hiding this comment.
One small change in functionality, and this thing should be ready to rock! Looks like a rebase is needed now as well.
@philip-peterson I'll make sure not to merge anything else until this lands, just to avoid excessive rebasing.
There was a problem hiding this comment.
+1
@philip-peterson && @hamza1311 thanks for all of the work on this PR. I'll update the changelog tonight and get things prepped for a new release.
This is a rebase, refactoring, and extension of PR #69. Thanks to @hamza1311 for starting the initial draft. Unfortunately during the rebase the changes @hamza1311 made were lost because the file they were in has been deleted upstream, but let's be sure that attribution makes it through this PR.
Happy to answer any questions. The main takeaway is that we now have two kinds of
distdirectory: staging and final. Plugins should output to staging, and Trunk itself moves things from staging to final. In theory, a plugin could put files in final itself which is pretty undesirable. If we move to untrusted plugins, this might be a good action to restrict.Checklist