-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minify assets for --release builds #7
Comments
How about also optimizing PNGs? |
Sounds good to me. I’ll add it to the list above. Any ideas on libraries/algorithms we can use to accomplish this? I can’t say I’ve done much PNG optimization, I’d have to do some research on it. |
We can add a new pipeline handler which handles PNGs specifically and does optimization as part of the pipeline. |
Seems like oxipng is absolutely perfect for this task. |
@MartinKavik agreed. Release mode still makes a big difference, however there is no wasm-opt integration quite yet. We definitely need to get that added in. |
How about minifying the generated JavaScript? |
Tried implementing this, but the JS minifiers I found on crates.io had problems - one broke wasm-bindgen generated JavaScript and the other couldn't parse it properly, but the author seems fairly active on github so I created an issue on his parser. Will create pull request for CSS and HTML, but JS will have to wait and I feel that's the biggest bit. |
What is the state of JS minifiers in trunk 18? The documentation on the website says that |
Trunk 0.18.0 adds minification of css and html too. If you find an issue I would ask you to raise a new issue, so that we can track it. At best, having a reproducer would be helpful. |
This primarily applies to:
The text was updated successfully, but these errors were encountered: