Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize wasm file with wasm-opt #114

Closed
dnaka91 opened this issue Jan 29, 2021 · 2 comments · Fixed by #115
Closed

Optimize wasm file with wasm-opt #114

dnaka91 opened this issue Jan 29, 2021 · 2 comments · Fixed by #115

Comments

@dnaka91
Copy link
Contributor

dnaka91 commented Jan 29, 2021

I just found this project randomly through an article from Rust weekly and directly tried it out. Very great tool so far and really reduces the amount of boilerplate currently required with the wasm-pack workflow.

What I would wish for is the integration with wasm-opt to further reduce the size of the resulting wasm file as it's done in wasm-pack as final step.

If there is interest on integrating wasm-opt, then I could add the changes and open a PR in a few days.
@MartinKavik
Copy link
Contributor

@dnaka91 We would be very grateful for the wasm-opt integration. See #7 (comment).

@dnaka91
Copy link
Contributor Author

dnaka91 commented Jan 29, 2021

Oh thanks, I didn't see that (as it was only in the comments).

My issue is quite a duplicate then I guess. Or can we use this to track any further questions regarding the wasm-opt integration @thedodd ?

@dnaka91 dnaka91 mentioned this issue Jan 30, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Integrate wasm-opt into the rust-app pipeline
2 participants
@MartinKavik @dnaka91