trunk 0.8.0 fails to build if the target directory does not already exist
#124
Comments
|
I think this might be the culprit: https://github.com/thedodd/trunk/blob/master/src/config/manifest.rs#L25
|
|
@jbg cryptic errors like that are the worst! I thought we got rid of all of them. Your analysis may indeed be correct. I'll repro and verify a fix. We should be able to get a 0.8.1 fix out pretty quickly. |
|
@jbg you were indeed correct. Turns out the cargo metadata already returns that path as a canonical path, so there was no need for us to be attempting to canonicalize it to begin with. I've made the fix, and verified that it does indeed address the issue. Thanks for the report! |
|
|
|
Sorry to chime in with the bad news, but the fix in |
|
@tommket that is actually what I did to verify that 0.8.1 actually did indeed resolve the issue. Let me try again, it is always possible that I messed up. Do you mind just also double-checking and making sure that you are indeed on 0.8.1 and not 0.8.0? |
|
Alas, it appears as though you are correct. I apparently did not verify the fix as thoroughly as I thought. I will re-open and fix ASAP. |
This time, the path was being canonicalized in another location. My original verification apparently did not account for this. All calls to `canonicalize` have been audited, and every location where such is called, it is also expected that the path exist, and is indeed considered an error if it does not exist.
This time, the path was being canonicalized in another location. My original verification apparently did not account for this. All calls to `canonicalize` have been audited, and every location where such is called, it is also expected that the path exist, and is indeed considered an error if it does not exist.
This time, the path was being canonicalized in another location. My original verification apparently did not account for this. All calls to `canonicalize` have been audited, and every location where such is called, it is also expected that the path exist, and is indeed considered an error if it does not exist.
This time, the path was being canonicalized in another location. My original verification apparently did not account for this. All calls to `canonicalize` have been audited, and every location where such is called, it is also expected that the path exist, and is indeed considered an error if it does not exist.
|
@tommket && @jbg I've just released Thanks for you patience! I got sick on Friday 12th, otherwise I would have released these changes earlier. Cheers |
To reproduce:
Expected: trunk behaves as cargo does and creates the necessary target directories.
Actual: trunk crashes with a cryptic error:
but the cause can be discovered using
strace:The text was updated successfully, but these errors were encountered: