Skip to content

Commit

Permalink
Add data-inline to SASS/SCSS (close #158)
Browse files Browse the repository at this point in the history 
Allows for compiling and then in-lining SASS and SCSS using a new
data-inline attribute in a data-trunk link tag.

Compiling SASS and SCSS without inlining is still supported.

This commit also fixes several spelling mistakes and updates
documentation to reflect the changes.

A non-squash version can be found at Bernd-L:inline-scss_no-squash,
in case you want to see individual commits or for reverting
individual changes.
  • Loading branch information
@Tanja-4732
Tanja-4732 authored Apr 13, 2021
1 parent 898e96f commit ef855d3
Show file tree
Hide file tree
Showing 21 changed files with 145 additions and 107 deletions.
1 change: 1 addition & 0 deletions .gitignore
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
target
dist
site/public/*
.vscode
5 changes: 3 additions & 2 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Subheadings to categorize changes are `added, changed, deprecated, removed, fixe

## Unreleased
### added
- Closed [#158](https://github.com/thedodd/trunk/issues/158): Support for inlining SASS/SCSS after compilation using the new `data-inline` attribute
- Closed [#145](https://github.com/thedodd/trunk/issues/145): Preloading of the WASM and JS files are now added to the `<head>` element. This ensures that the code starts downloading as soon as possible, and can make your app start up a few seconds earlier on a slow network.

### fixed
Expand All @@ -22,7 +23,7 @@ Subheadings to categorize changes are `added, changed, deprecated, removed, fixe

## 0.9.1
### fixed
- Fixed a bug releated to the watch system, which would cause build loops if there was an error on the initial build.
- Fixed a bug related to the watch system, which would cause build loops if there was an error on the initial build.

## 0.9.0
### added
Expand All @@ -34,7 +35,7 @@ Added support for proxying WebSockets. This was a long-standing feature request.

### fixed
- Closed [#81](https://github.com/thedodd/trunk/issues/81): this is no longer needed as we now have support for WebSockets. HTTP2 is still outstanding, but that will not be a blocker for use from the web.
- Closed [#95](https://github.com/thedodd/trunk/issues/95): fixed via a few small changes to precendce in routing.
- Closed [#95](https://github.com/thedodd/trunk/issues/95): fixed via a few small changes to precedence in routing.
- Closed [#53](https://github.com/thedodd/trunk/issues/53): we've now implemented support for proxying WebSockets.

## 0.8.3
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ We are all living beings, and what is most important is that we respect each oth
## hacking
Just a few simple items to keep in mind as you hack.

- Pull request early and often. This helps to let others know what you are working on. **Please use Github's Draft PR mechansim** if your PR is not yet ready for review.
- Pull request early and often. This helps to let others know what you are working on. **Please use Github's Draft PR mechanism** if your PR is not yet ready for review.
- Remember to update the `CHANGELOG.md` once you believe your work is nearing completion.

## linting
Expand Down
Loading

0 comments on commit ef855d3

Please sign in to comment.