Skip to content

Commit

Permalink
Refactor VoilaApp
Browse files Browse the repository at this point in the history
  • Loading branch information
trungleduc committed Aug 31, 2023
1 parent 909c167 commit a2c3766
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
6 changes: 3 additions & 3 deletions packages/voila/src/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export class VoilaApp extends JupyterFrontEnd<IShell> {
/**
* The name of the application.
*/
readonly name = 'Voila';
readonly name: string = 'Voila';

/**
* A namespace/prefix plugins may use to denote their provenance.
Expand Down Expand Up @@ -136,8 +136,8 @@ export class VoilaApp extends JupyterFrontEnd<IShell> {
return this._widgetManager;
}

private _widgetManager: KernelWidgetManager | null = null;
private _widgetManagerPromise = new PromiseDelegate<KernelWidgetManager>();
protected _widgetManager: KernelWidgetManager | null = null;
protected _widgetManagerPromise = new PromiseDelegate<KernelWidgetManager>();
}

/**
Expand Down
1 change: 0 additions & 1 deletion packages/voila/src/plugins/widget.ts
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@ export const renderOutputsPlugin: JupyterFrontEndPlugin<void> = {
const cellOutputs = document.body.querySelectorAll(
'script[type="application/vnd.voila.cell-output+json"]'
);

cellOutputs.forEach(async (cellOutput) => {
const model = JSON.parse(cellOutput.innerHTML);

Expand Down

0 comments on commit a2c3766

Please sign in to comment.