This repository has been archived by the owner on Mar 11, 2024. It is now read-only.
Feature/246 remove deprecated networks #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revised the network lists post merge. Still issue with infura returned values but that will be fixed their end.
fixing imports.
Added in code to use actual internal requirements from our Constants.ts file. This also adds in colouring and dynamic changes into the HTML on prereqs .html page now.
michaeljohnbennett
added
the
doc-change-required
acuarica
reviewed
Oct 28, 2022
| RINKEBY = 4, | ||
| GÖRLI = 5, | ||
| KOVAN = 42, | ||
| GOERLI = 5, |
There was a problem hiding this comment.
Thanks for renaming this! Good catch.
bgravenorst
removed
the
doc-change-required
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Fixing the deprecated networks list.
Documentation
doc-change-requiredlabel to this PR if documentation updates are required.We may need to note that we now have a hard min limit of Ganache support post merge to 7.4.3 as this was the first version to support Sepolia as a forked network.