Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Dependency update: Bump web3 to version 1.2.2 & implement typings #2558

Merged
merged 58 commits into from
Nov 7, 2019
Merged

Dependency update: Bump web3 to version 1.2.2 & implement typings #2558

merged 58 commits into from
Nov 7, 2019

Conversation

CruzMolina
Copy link
Contributor

@CruzMolina CruzMolina commented Nov 5, 2019 •
edited
Loading

Continuation of #2488. Also adjusts & migrates typings from @types/web3 to various web3@1.2.2 pkg typings.

eggplantzzz and others added 30 commits October 24, 2019 10:23
@eggplantzzz
Bump web3 to version 1.2.2
523e6d0
@eggplantzzz
Regenerate yarn.lock
4b66872
@eggplantzzz
Merge in develop branch
f42aae3
@CruzMolina
rm @types/web3 path ref (box/tsconfig)
eb769b8
@CruzMolina
rm @types/web3 path ref (artifactor/tsconfig)
36636da
@CruzMolina
rm @types/web3 path ref (decode-utils/tsconfig)
c0516ed
@CruzMolina
rm @types/web3 path ref (blockchain-utils/tsconfig)
bd0d76f
@CruzMolina
rm @types/web3 path ref (code-utils/tsconfig)
fd4ca1a
@CruzMolina
updated yarn.lock
98f343d
@CruzMolina
yarn remove @types/web3 (decoder)
9611f38
@CruzMolina
rm @types/web3 path refs (decoder/tsconfig)
1554a18
@CruzMolina
rm @types/web3 typeRoots ref (blockchain-utils/tsconfig)
150b027
@CruzMolina
yarn remove @types/web3 (blockchain-utils)
049c353
@CruzMolina
yarn remove @types/web3 (decode-utils)
534c121
@CruzMolina
rm @types/web3 path refs (interface-adapter/tsconfig)
ae12178
@CruzMolina
yarn remove @types/web3 (interface-adapter)
1033937
@CruzMolina
yarn add -D @types/node web3-core-helpers (blockchain-utils)
4d3084f
@CruzMolina
add paths ref for Net module typings (blockchain-utils/tsconfig)
44497df
@CruzMolina
import Provider typings from web3-core-helpers (blockchain-utils/index)
7b02eef
@CruzMolina
create union Provider type (blockchain-utils/index)
e728f41
@CruzMolina
pull out JsonRpcResponse interface from @types/web3 (blockchain-utils…
0cc7101 
…/index)
@CruzMolina
pull out Callback interface from @types/web3 (blockchain-utils/index)
d2f7061
@CruzMolina
adjust JsonRpcResponse vars for correct camelCasing (blockchain-utils…
2d99351 
…/index)
@CruzMolina
mv typings into type def file & import appropriately (blockchain-utils)
68594a5
@CruzMolina
import & use typings from @truffle/blockchain-utils (hdwallet-provide…
31f7f1b 
…r/src/index)
@CruzMolina
import & use typings from @truffle/blockchain-utils (hdwallet-provide…
3421325 
…r/typings/web3-provider-engine/index)
@CruzMolina
yarn add @truffle/blockchain-utils (hdwallet-provider)
ff8b743
@CruzMolina
incl blockchain-utils typings in typeRoots (hdwallet-provider/tsconfig)
41f31d1
@CruzMolina
yarn remove web3 && yarn add -D web3 (hdwallet-provider)
330dcef
@CruzMolina
mv more typings into type def file & import appropriately (blockchain…
9e4ac63 
…-utils)
@CruzMolina CruzMolina changed the title Dependency update: Bump web3 to version 1.2.2 & implement typings & Bug fix: Properly apply gasMultiplier to gasEstimates Dependency update: Bump web3 to version 1.2.2 & implement typings Nov 6, 2019
@coveralls
Copy link

coveralls commented Nov 6, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 74.12% when pulling 66764d7 on update-web3-types into 60babc3 on develop.

@cgewecke cgewecke mentioned this pull request Nov 6, 2019
Merged
@eggplantzzz eggplantzzz mentioned this pull request Nov 7, 2019
Closed
@eggplantzzz
Copy link
Contributor

Ok I think this is cool with me when it passes CI.

@CruzMolina CruzMolina merged commit c3c6c03 into develop Nov 7, 2019
@CruzMolina CruzMolina deleted the update-web3-types branch November 7, 2019 21:22
This was referenced Dec 3, 2019
Closed
Closed
CruzMolina added a commit that referenced this pull request Dec 10, 2019
@CruzMolina
Revert "Merge pull request #2558 from trufflesuite/update-web3-types"
f282713 
This reverts commit c3c6c03, reversing
changes made to 60babc3.
CruzMolina added a commit that referenced this pull request Dec 10, 2019
@CruzMolina
Revert "Merge pull request #2558 from trufflesuite/update-web3-types"
1dcfb41 
This reverts commit c3c6c03, reversing
changes made to 60babc3.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cgewecke cgewecke cgewecke left review comments

@eggplantzzz eggplantzzz eggplantzzz approved these changes

@gnidan gnidan Awaiting requested review from gnidan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CruzMolina @coveralls @eggplantzzz @gnidan @cgewecke