Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Test Web3.js 1.0 release by adding yarn link step to Travis install #2182

Closed
wants to merge 10 commits into from
Closed

Test Web3.js 1.0 release by adding yarn link step to Travis install #2182

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3ff5a6f
Add link script for testing web3
gnidan Jul 12, 2019
49afaaa
Use https
gnidan Jul 12, 2019
29bd8c8
Remember how to write a for loop
gnidan Jul 12, 2019
eb14ba9
Stop being so careless
gnidan Jul 12, 2019
93cb9fb
Perform extra bootstrap
gnidan Jul 12, 2019
976f101
just make it work
CruzMolina Jul 12, 2019
226c1b4
Try using yalc instead of yarn link
gnidan Jul 12, 2019
f93f085
Revert "just make it work"
gnidan Jul 12, 2019
dc8cd1a
Add missing dependencies
gnidan Jul 12, 2019
736c4d2
Remove AbiItem type, use any
gnidan Jul 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/truffle-decode-utils/src/contexts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ const debug = debugModule("decode-utils:contexts");

import { Abi } from "truffle-contract-schema/spec";
import { AbiCoder } from "web3-eth-abi";
import { AbiItem } from "web3-utils";
const abiCoder = new AbiCoder();
import escapeRegExp from "lodash.escaperegexp";

Expand Down Expand Up @@ -97,7 +96,7 @@ export namespace Contexts {
debug("signature read: %s", signature);
//if not, compute it ourselves
if(signature === undefined) {
signature = abiCoder.encodeFunctionSignature(<AbiItem>abiEntry);
signature = abiCoder.encodeFunctionSignature(<any>abiEntry);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing this since #2214 demonstrates the same AbiItem failure as on this branch, and I think this shouldn't impact the web3 release validation.

//Notice the type coercion -- web3 and our schema describe things a little
//differently, and TypeScript complains. I think we just have to force it,
//sorry.
Expand Down