-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Conversation
Thanks for this! Does this also need the package.json files updated? Or do they already account for the new versions? EDIT: Oh, did you just delete the yarn.lock and regenerate it? |
This is probably enough because sha3 is required with I didn't delete and regenerate yarn.lock. I just tried to upgrade sha3 to 1.2.3. But it looks like yarn did that 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @filips123 !
Verified locally that this is indeed a simple yarn upgrade
that upgrades the resolved sha3 dependency to 1.2.3.
Before yarn upgrade
: https://travis-ci.com/filips123/truffle/jobs/204732468#L796 (failing on node 12 because of sha3
)
After yarn upgrade
: https://travis-ci.com/filips123/truffle/jobs/204809466#L737 (failing on node 12 because of scrypt
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was hesitating about the pros/cons of this approach, since there's potential risk upgrading all the packages en masse, but I second @CruzMolina's approval. The risk is relatively low, and potential problems are likely to be easy to mitigate.
Thanks again @filips123 for helping to address the lack of Node v12 support!
Update dependencies in
yarn.lock
. Related to #2070 and resolvedsha3
issue. There is still a problem withscrypt
because it is used by old Web3 versions.