Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Update dependencies #2071

Merged
merged 1 commit into from
Jun 5, 2019
Merged

Conversation

filips123
Copy link
Contributor

Update dependencies in yarn.lock. Related to #2070 and resolved sha3 issue. There is still a problem with scrypt because it is used by old Web3 versions.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 70.123% when pulling f700c95 on filips123:update-dependencies into 37e99cc on trufflesuite:develop.

@gnidan
Copy link
Contributor

gnidan commented Jun 2, 2019

Thanks for this!

Does this also need the package.json files updated? Or do they already account for the new versions?

EDIT: Oh, did you just delete the yarn.lock and regenerate it?

@filips123
Copy link
Contributor Author

filips123 commented Jun 3, 2019

This is probably enough because sha3 is required with ^1.2.2 which will also require 1.2.3.

I didn't delete and regenerate yarn.lock. I just tried to upgrade sha3 to 1.2.3. But it looks like yarn did that 😀

Copy link
Contributor

@CruzMolina CruzMolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @filips123 !

Verified locally that this is indeed a simple yarn upgrade that upgrades the resolved sha3 dependency to 1.2.3.

Before yarn upgrade: https://travis-ci.com/filips123/truffle/jobs/204732468#L796 (failing on node 12 because of sha3)
After yarn upgrade: https://travis-ci.com/filips123/truffle/jobs/204809466#L737 (failing on node 12 because of scrypt)

Copy link
Contributor

@gnidan gnidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hesitating about the pros/cons of this approach, since there's potential risk upgrading all the packages en masse, but I second @CruzMolina's approval. The risk is relatively low, and potential problems are likely to be easy to mitigate.

Thanks again @filips123 for helping to address the lack of Node v12 support!

@gnidan gnidan merged commit 60e41da into trufflesuite:develop Jun 5, 2019
CruzMolina added a commit that referenced this pull request Jun 13, 2019
CruzMolina added a commit that referenced this pull request Jun 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants