This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Use specified solc version range to determine which solc to download #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnidan
changed the title
gnidan
reviewed
Nov 29, 2018
| if (satisfyingVersions.length > 0) { | ||
| return satisfyingVersions.reduce((newestVersion, version) => { | ||
| if (semver.gtr(version, newestVersion)) return version; | ||
| }, "0.0.0"); |
| solcVersion => { | ||
| if (semver.satisfies(solcVersion, version)) return solcVersion; | ||
| } | ||
| ); |
There was a problem hiding this comment.
We can use const instead of let here if you just tack the filter onto the end... can even get rid of the extra if in the filter
Suggested change
| ); | |
| ).filter(v => v); |
There was a problem hiding this comment.
Oh that is a nice, concise solution.
| if (semver.satisfies(solcVersion, version)) return solcVersion; | ||
| } | ||
| ); | ||
| satisfyingVersions = satisfyingVersions.filter(solcVersion => { |
There was a problem hiding this comment.
Suggested change
| satisfyingVersions = satisfyingVersions.filter(solcVersion => { |
| } | ||
| ); | ||
| satisfyingVersions = satisfyingVersions.filter(solcVersion => { | ||
| if (solcVersion) return solcVersion; |
There was a problem hiding this comment.
Suggested change
| if (solcVersion) return solcVersion; |
| ); | ||
| satisfyingVersions = satisfyingVersions.filter(solcVersion => { | ||
| if (solcVersion) return solcVersion; | ||
| }); |
There was a problem hiding this comment.
(I wish I could do a multi-line suggestion)
| .catch(err => { | ||
| spinner.stop(); | ||
| throw self.errors("noRequest", url, err); | ||
| }); |
gnidan
approved these changes
Nov 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the compilerSupplier to support version constraints.