This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Suppress anonymous output parameters from data.current.identifiers. #1476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnidan
approved these changes
Nov 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request prevents anonymous output parameters from displaying (with the empty string for a name) when the user hits
v, by excluding them fordata.current.identifiers. The empty string for a name is confusing, and it doesn't really make sense to display such parameters in the first place as they'll basically only ever contain nonsense except at the very end of their lifetime. (I didn't bother adding any tests in this PR.)