Upgrade test contracts to 0.5.0 and fix all resulting problems #1465

haltman-at · 2018-11-26T22:13:13Z

[Note: This branch is kind of a mess; it might not end up getting merged in as such.]

This branch upgrades all the test contracts to 0.5.0, and attempts to fix all the resulting problems. I've already fixed one such problem, namely the lack of support for STATICCALL, in PR #1446. But there's more.

One issue that's come up is that a number of my tests are quite shaky. This isn't an 0.5.0 problem, but I in my investigations I think I've figured out what's causing it anyway -- namely, I was relying on sourceId to be consistent between runs, when it's not. That's an easy fix.

But the real problems are the 0.5.0-specific problems, which are very consistent. The failing tests (now that I've fixed the storage decoding tests, where the problem was STATICCALL) are:

The memory decoding tests
The variable IDs tests
The two mapping tests where the domain is numeric

Note that these errors exist also, in near-identical form, on the truffle-decoder branch; I made a separate branch for testing that, namely decoder-0.5.0-tests, which see.

The memory decoding tests, as best I can tell, do seem to be due to a decoding problem. However, I'm not certain of this.

The variable ID tests seem to be due to some difference in how variable declarations are handled, except for one of them which also seems to be due to a decoding problem like above. Again, all this is uncertain.

The two mapping tests... I'd say also a decoding problem, probably, but a different one. However I've made no real exploration of this at all.

Basically, I don't know what's going on, but that's my current progress. Will update.

haltman-at · 2018-11-27T00:56:31Z

Note: The intermittent failure should now be addressed due to PR #1466.

gnidan · 2018-11-28T01:02:28Z

packages/truffle-debugger/test/helpers.js

+      {
+        unsafeCleanup: true,
+        setGracefulCleanup: true,
+        name: "default#web3-one"


This change is necessary for Migrations.sol

gnidan · 2018-11-28T01:02:49Z

packages/truffle-config/index.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-unused-vars */


We should probably get rid of this

gnidan · 2018-11-28T01:03:13Z

packages/truffle-debugger/test/ast.js


 const __VARIABLES = `
-pragma solidity ^0.4.18;
+pragma solidity ~0.5;


These of course are necessary

gnidan · 2018-11-28T01:03:47Z

packages/truffle-debugger/test/context.js

@@ -11,7 +11,7 @@ import Debugger from "lib/debugger";
 import sessionSelector from "lib/session/selectors";

 const __OUTER = `
-pragma solidity ^0.4.18;
+pragma solidity ~0.5;


gnidan · 2018-11-28T01:03:52Z

packages/truffle-debugger/test/context.js

@@ -33,7 +33,7 @@ contract OuterContract {
 `;

 const __INNER = `
-pragma solidity ^0.4.18;
+pragma solidity ~0.5;


gnidan · 2018-11-28T01:06:13Z

packages/truffle-debugger/test/evm.js

@@ -1,10 +1,9 @@
 import debugModule from "debug";


yep these too

gnidan · 2018-11-28T01:06:28Z

packages/truffle-debugger/test/helpers.js

-      version: "0.4.25"
-    }
-  };
-


Gotta put this back in and turn the version up, apparently!

gnidan · 2018-11-28T01:08:22Z

packages/truffle-debugger/test/precompiles.js

@@ -1,10 +1,9 @@
 import debugModule from "debug";


gnidan · 2018-11-28T01:08:28Z

packages/truffle-debugger/test/reset.js

@@ -12,14 +12,14 @@ import data from "lib/data/selectors";
 import solidity from "lib/solidity/selectors";


gnidan · 2018-11-28T01:08:33Z

packages/truffle-debugger/test/solidity.js

@@ -12,7 +12,7 @@ import solidity from "lib/solidity/selectors";
 import trace from "lib/trace/selectors";


haltman-at · 2018-11-28T02:46:28Z

OK, the optimizer has now been turned off for the tests (thanks @gnidan), solving most of the problems.

In addition, I've passed the files argument to prepareDebugger in tests that were previously missing it, which should (independently of the 0.5.0 update) fix their intermittent failures.

A word of warning, the compiler version is currently set to 0.5.0 rather than ^0.5.0; this is because the latter doesn't work on my machine. We'll have to figure out some way of getting the latter to work, because we don't want to have to constantly update the version every time there's a new version of solc.

coveralls · 2018-11-28T03:32:25Z

Coverage decreased (-0.03%) to 67.51% when pulling 2b5a836 on solc-0.5.0-tests into b81fa2f on next.

haltman-at added the wip label Nov 27, 2018

gnidan reviewed Nov 28, 2018

View reviewed changes

gnidan force-pushed the solc-0.5.0-tests branch from c12afff to fcd4195 Compare November 28, 2018 01:25

haltman-at removed the wip label Nov 28, 2018

haltman-at changed the title ~~[WIP] Upgrade test contracts to 0.5.0 and fix all resulting problems~~ Upgrade test contracts to 0.5.0 and fix all resulting problems Nov 28, 2018

gnidan force-pushed the solc-0.5.0-tests branch from 30f0155 to 2e1e2d7 Compare November 28, 2018 20:50

haltman-at added 2 commits November 28, 2018 17:05

Remove extraneous function argument.

5e74483

Upgrade test contracts to solidity 0.5.0.

b15c5da

gnidan force-pushed the solc-0.5.0-tests branch from 2e1e2d7 to 10f4cb8 Compare November 28, 2018 22:08

gnidan and others added 2 commits November 28, 2018 17:09

Update BYOC version to 0.5.0

f7d8e18

Make sure to pass files when starting debugger.

2b5a836

gnidan force-pushed the solc-0.5.0-tests branch from 10f4cb8 to 2b5a836 Compare November 28, 2018 22:10

gnidan merged commit a4be893 into next Nov 28, 2018

gnidan deleted the solc-0.5.0-tests branch November 28, 2018 22:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade test contracts to 0.5.0 and fix all resulting problems #1465

Upgrade test contracts to 0.5.0 and fix all resulting problems #1465

haltman-at commented Nov 26, 2018

haltman-at commented Nov 27, 2018

gnidan Nov 28, 2018

gnidan Nov 28, 2018

gnidan Nov 28, 2018

gnidan Nov 28, 2018

gnidan Nov 28, 2018

gnidan Nov 28, 2018

gnidan Nov 28, 2018

gnidan Nov 28, 2018

gnidan Nov 28, 2018

gnidan Nov 28, 2018

haltman-at commented Nov 28, 2018

coveralls commented Nov 28, 2018 •

edited

Loading

		@@ -12,14 +12,14 @@ import data from "lib/data/selectors";
		import solidity from "lib/solidity/selectors";

		@@ -12,7 +12,7 @@ import solidity from "lib/solidity/selectors";
		import trace from "lib/trace/selectors";

Upgrade test contracts to 0.5.0 and fix all resulting problems #1465

Upgrade test contracts to 0.5.0 and fix all resulting problems #1465

Conversation

haltman-at commented Nov 26, 2018

haltman-at commented Nov 27, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

haltman-at commented Nov 28, 2018

coveralls commented Nov 28, 2018 • edited Loading

coveralls commented Nov 28, 2018 •

edited

Loading