This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Tweak options for sane library #1460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…led, give a note to users that they can download watchmand if they have problems using the command
gnidan
reviewed
Nov 26, 2018
| config.logger.log( | ||
| colors.yellow( | ||
| "If you have trouble using watch, try installing watchman." | ||
| ) |
There was a problem hiding this comment.
If only displaying this message in a catch is not an option, can we remove the yellow here? That way the message will be more ignorable, but still easy enough to find if you're looking at an unhandled exception.
There was a problem hiding this comment.
Sounds fine to me
gnidan
approved these changes
Nov 26, 2018
There was a problem hiding this comment.
I'll just approve this now so I don't have to do it later. Feel free to make the change if you agree, or leave it. Thanks @eggplantzzz!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a different option to attempt to cope with watching big codebases.
See the different modes in the docs.
https://www.npmjs.com/package/sane