Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Make debugger fail less hard #1174

Merged
merged 4 commits into from
Aug 10, 2018
Merged

Make debugger fail less hard #1174

merged 4 commits into from
Aug 10, 2018

Conversation

gnidan
Copy link
Contributor

@gnidan gnidan commented Aug 9, 2018

Might fix some problems in trufflesuite/truffle-debugger#75

  • Continue stepping through Solidity code if controller.current.location causes an error
  • Use more defaults to prevent unhandled "cannot read whatever of undefined" exceptions

@gnidan gnidan changed the title Skip over unknown source locations when debugging Make debugger fail less hard Aug 10, 2018
@gnidan
Copy link
Contributor Author

gnidan commented Aug 10, 2018

@seesemichaelj Adding you for review just in case you're interested in getting your eyes on the truffle-debugger. Feel free to disregard.

Thoughts: definitely need to come up with a better strategy for dealing with the debugger when it's in the state of "I don't know where I am!!!" This class of failure case has been entirely disregarded and that needs to be rectified in a more substantial way, instead of these if (!something) return whatever; that just shift the unknown down the line. One idea would involve a conversion to TypeScript, then making use of a Maybe<T> or Option<T> type.

@gnidan
Copy link
Contributor Author

gnidan commented Aug 10, 2018

Note: using the reproduction steps in uport-project/ethr-did-registry#9, I was able to successfully step through the debugger without a single exception (using ; for highest granularity).

@gnidan
Copy link
Contributor Author

gnidan commented Aug 10, 2018

Thanks @cgewecke!

@seesemichaelj I am merging this, just wanted you to have the notification should you be interested.

@gnidan gnidan merged commit ba5165f into develop Aug 10, 2018
@gnidan gnidan deleted the debug-skip-unknown-locations branch August 10, 2018 21:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants