Cache chain ID to avoid extra network requests

trufflesuite · Mar 24, 2021 · b626080 · b626080
1 parent e6f61f1
commit b626080
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/packages/contract/lib/contract/constructorMethods.js b/packages/contract/lib/contract/constructorMethods.js
@@ -29,6 +29,9 @@ module.exports = Contract => ({
     // save properties
     this.currentProvider = provider;
     this.networkType = networkType;
+
+    //invalidate cached chain ID
+    this._chainId = undefined;
   },
 
   setProvider(provider) {

diff --git a/packages/contract/lib/execute.js b/packages/contract/lib/execute.js
@@ -527,8 +527,17 @@ const execute = {
   sendTransaction: async function (web3, params, promiEvent, context) {
     // get the chainId to be compliant with EIP-155
     // Geth wants this value in base 16 prefixed by "0x"
-    const chainId = await web3.eth.net.getId();
-    params.chainId = `0x${chainId.toString(16)}`;
+    let chainId;
+    if (context.contract._chainId) {
+      chainId = context.contract._chainId;
+    } else {
+      chainId = await web3.eth.net.getId();
+      chainId = `0x${chainId.toString(16)}`;
+      //cache it in a field on the contract
+      //(I'd do this in setProvider instead of here, but that's not async)
+      context.contract._chainId = chainId;
+    }
+    params.chainId = chainId;
 
     //if we don't need the debugger, let's not risk any errors on our part,
     //and just have web3 do everything